Sergei Trofimovich authored 5 years ago and Marge Bot committed 5 years ago

Be more precise at detecting cross-compilation case.

Before the change configuration
  $ ./configure --host=x86_64-pc-linux-gnu --target=x86_64-gentoo-linux-musl
was not considered a cross-target. Even though libcs are different (`glibc` vs. `musl`).

Without this patch build fails as:

```
"inplace/bin/ghc-cabal" check libraries/integer-gmp
"inplace/bin/ghc-cabal" configure libraries/integer-gmp dist-install \
    --with-ghc="/home/slyfox/dev/git/ghc/inplace/bin/ghc-stage1" \
    --with-ghc-pkg="/home/slyfox/dev/git/ghc/inplace/bin/ghc-pkg" \
    --disable-library-for-ghci --enable-library-vanilla --enable-library-for-ghci \
    --enable-library-profiling --enable-shared --with-hscolour="/usr/bin/HsColour" \
    --configure-option=CFLAGS="-Wall \
    -Werror=unused-but-set-variable -Wno-error=inline \
    -iquote /home/slyfox/dev/git/ghc/libraries/integer-gmp" \
    --configure-option=LDFLAGS="  " --configure-option=CPPFLAGS="   \
    " --gcc-options="-Wall     -Werror=unused-but-set-variable -Wno-error=inline -iquote /home/slyfox/dev/git/ghc/libraries/integer-gmp   \
    " --with-gcc="x86_64-gentoo-linux-musl-gcc" --with-ld="x86_64-gentoo-linux-musl-ld.gold" --with-ar="x86_64-gentoo-linux-musl-ar" \
    --with-alex="/usr/bin/alex" --with-happy="/usr/bin/happy"
Configuring integer-gmp-1.0.2.0...
configure: WARNING: unrecognized options: --with-compiler
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking target system type... x86_64-pc-linux-gnu
checking for gcc... /usr/lib/ccache/bin/x86_64-gentoo-linux-musl-gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... configure: error: in `/home/slyfox/dev/git/ghc/libraries/integer-gmp/dist-install/build':
configure: error: cannot run C compiled programs.
If you meant to cross compile, use `--host'.
See `config.log' for more details
make[1]: *** [libraries/integer-gmp/ghc.mk:5: libraries/integer-gmp/dist-install/package-data.mk] Error 1
make: *** [Makefile:126: all] Error 2
```

Note: here `ghc-stage1` is assumed to target `musl` target but is passed
`glibc` toolchain. It happens because initial ./configure phase did not
detect host/target as different.

Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Previously we were using AC_DEFINE instead of
AC_DEFINE_UNQUOTED, resulted in the variable not being
interpolated.

Fixes #17505.

Bumps haddock submodule.

Takenobu Tani authored 5 years ago and Marge Bot committed 5 years ago

If sphinx's python version check failed, many people prefer to build
without documents instead of stopping on the error.

So this commit fixes the following:

* Modify AC_MSG_ERROR to AC_MSG_WARN
* Add clearing of SPHINXBUILD variable when check fails

See also !2016.

Takenobu Tani authored 5 years ago and Marge Bot committed 5 years ago

This checks the configuration about python3-sphinx.
We need python3-sphinx instead of python2-sphinx to build documentation.

The approach is as follows:
* Check python3 version with custom `conf.py` invoked from
  sphinx-build` executable
* Place custom `conf.py` into new `utils/check-sphinx` directory

If sphinx is for python2 not python3, it's treated as config ERROR
instead of WARN.

See also #17346 and #17356.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Fixing #17255.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

This had silently regressed due to 81860281 and the variable renaming performed
in b55ee979, as noted in #17374.

Stefan Schulze Frielinghaus authored 5 years ago and Marge Bot committed 5 years ago

This patch adds support for the s390x architecture for the LLVM code
generator. The patch includes a register mapping of STG registers onto
s390x machine registers which enables a registerised build.

John Ericson authored 5 years ago and Marge Bot committed 5 years ago

 - No need to distinguish between gcc-llvm and clang. First of all,
   gcc-llvm is quite old and surely unmaintained by now. Second of all,
   none of the code actually care about that distinction!

   Now, it does make sense to consider C multiple frontends for LLVMs in
   the form of clang vs clang-cl (same clang, yes, but tweaked
   interface). But this is better handled in terms of "gccish vs
   mvscish" and "is LLVM", yielding 4 combinations. Therefore, I don't
   think it is useful saving the existing code for that.

 - Get the remaining CC_LLVM_BACKEND, and also TABLES_NEXT_TO_CODE in
   mk/config.h the normal way, rather than hacking it post-hoc. No point
   keeping these special cases around for now reason.

 - Get rid of hand-rolled `die` function and just use `AC_MSG_ERROR`.

 - Abstract check + flag override for unregisterised and tables next to
   code.

Oh, and as part of the above I also renamed/combined some variables
where it felt appropriate.

 - GccIsClang -> CcLlvmBackend. This is for `AC_SUBST`, like the other
 Camal case ones. It was never about gcc-llvm, or Apple's renamed clang,
 to be clear.

 - llvm_CC_FLAVOR -> CC_LLVM_BACKEND. This is for `AC_DEFINE`, like the
 other all-caps snake case ones. llvm_CC_FLAVOR was just silly
 indirection *and* an odd name to boot.

John Ericson authored 5 years ago and Marge Bot committed 5 years ago

d679ca43 meant to remove it but did not
finish the job.

John Ericson authored 5 years ago and Marge Bot committed 5 years ago

We no longer support booting from older GHC since
527bcc41.

John Ericson authored 5 years ago and Marge Bot committed 5 years ago

Unused outside it since b6be81b8.

John Ericson authored 5 years ago and Marge Bot committed 5 years ago

It looks like it's been unused since at least
34cc75e1.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

These are needed by the user guide documentation. Fixes #17260.

Daniel Gröber (dxld) authored 5 years ago and Marge Bot committed 5 years ago

commit 795986aa ("Remove unneeded CPP now that GHC 8.6 is the minimum")
broke the 8.4 build.

John Ericson authored 5 years ago and Marge Bot committed 5 years ago

Some where using `True` / `False`, a legacy of when they were in
`Config.hs`. See #16914 / d238d306 for a similar problem.

Also clean up the configure variables names for consistency and clarity
while we're at it. "Target" makes clear we are talking about outputted
code, not where GHC itself runs.

Sergei Trofimovich authored 5 years ago and Marge Bot committed 5 years ago

Before the change ./configure detected numa support automatically
withoun a nice way to disable autodetection.

The change adds `--enable-numa` / `--disable-numa` switch to
override the default. If `--enable-numa` is passed and `libnuma`
is not present then configure will fail.

Reported-by: Sergey Alirzaev
Bug: https://github.com/gentoo-haskell/gentoo-haskell/issues/955


Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

Sergei Trofimovich authored 5 years ago and Marge Bot committed 5 years ago

Before the change
    ./configure --disable-dwarf-debug
enabled DWARF debugging unconditionally.

This happened due to use of 5-argument form of `AC_ARG_ENABLE`
without actually checking the passed  `$enableval` parameter:

```
AC_ARG_ENABLE(dwarf-unwind,
    [AC_HELP_STRING([--enable-dwarf-unwind],
        [Enable DWARF unwinding support in the runtime system via elfutils' libdw [default=no]])],
    [AC_CHECK_LIB(dw, dwfl_attach_state,
      [UseLibdw=YES],
      [AC_MSG_ERROR([Cannot find system libdw (required by --enable-dwarf-unwind)])])]
    [UseLibdw=NO]
)
```

Note:

- `[UseLibdw=NO]` is called when `--{enable,disable}-dwarf-unwind`
  is not passed at all as a parameter (ok).
- `[AC_CHECK_LIB(dw, dwfl_attach_state, [UseLibdw=YES],` is called
  for both:

  * `--enable-dwarf-unwind` being passed: `$enableval = "yes"` (ok).
  *  --disable-dwarf-unwind` being passed: `$enableval = "no"` (bad).

The change is to use 3-argument `AC_ARG_ENABLE` and check for passed
value as `"$enable_dwarf_unwind" = "yes"`.

Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

Joachim Breitner authored 6 years ago and Marge Bot committed 5 years ago

`TablesNextToCode` is now a substituted by configure, where it has the
correct defaults and error handling. Nowhere else needs to duplicate
that, though we may want the compiler to to guard against bogus settings
files.

I renamed it from `GhcEnableTablesNextToCode` to `TablesNextToCode` to:

 - Help me guard against any unfixed usages

 - Remove any lingering connotation that this flag needs to be combined
   with `GhcUnreigsterised`.

Original reviewers:

Original subscribers: TerrorJack, rwbarton, carter

Original Differential Revision: https://phabricator.haskell.org/D5082

roland authored 5 years ago and Marge Bot committed 5 years ago

Fixes #16857.

Erik de Castro Lopo authored 5 years ago and Marge Bot committed 5 years ago

LLVM version numberinf changed recently. Previously, releases were numbered
4.0, 5.0 and 6.0 but with version 7, they dropped the redundant ".0".

Fix requires for Llvm detection and some code.

John Ericson authored 5 years ago and Marge Bot committed 5 years ago

This allows it to eventually become stage-specific

Takenobu Tani authored 5 years ago and Marge Bot committed 5 years ago

This moves all URL references to Trac Wiki to their corresponding
GitLab counterparts.

This substitution is classified as follows:

1. Automated substitution using sed with Ben's mapping rule [1]
    Old: ghc.haskell.org/trac/ghc/wiki/XxxYyy...
    New: gitlab.haskell.org/ghc/ghc/wikis/xxx-yyy...

2. Manual substitution for URLs containing `#` index
    Old: ghc.haskell.org/trac/ghc/wiki/XxxYyy...#Zzz
    New: gitlab.haskell.org/ghc/ghc/wikis/xxx-yyy...#zzz

3. Manual substitution for strings starting with `Commentary`
    Old: Commentary/XxxYyy...
    New: commentary/xxx-yyy...

See also !539

[1]: https://gitlab.haskell.org/bgamari/gitlab-migration/blob/master/wiki-mapping.json

Ryan Scott authored 6 years ago and Marge Bot committed 6 years ago

This moves all URL references to Trac tickets to their corresponding
GitLab counterparts.

Ben Gamari authored 6 years ago and Marge Bot committed 6 years ago

The splitter is an evil Perl script that processes assembler code.
Its job can be done better by the linker's --gc-sections flag. GHC
passes this flag to the linker whenever -split-sections is passed on
the command line.

This is based on @DemiMarie's D2768.

Fixes Trac #11315
Fixes Trac #9832
Fixes Trac #8964
Fixes Trac #8685
Fixes Trac #8629

Moritz Angermann authored 6 years ago and Marge Bot committed 6 years ago

This adds trace messages that include the processes name and as such
make debugging and following the communication easier.

It also adds a note regarding the fwd*Call proxy-communication logic
between the proxy and the slave.

The proxy will now also poll for 60s to wait for the remote iserv
to come up. (Alternatively you can start the remote process
beforehand; and just have iserv-proxy connect to it)

Ryan Scott authored 6 years ago and Marge Bot committed 6 years ago

Along the way, I discovered that `template-haskell.cabal` was
hard-coding the GHC version (in the form of its `ghc-boot-th` version
bounds), so I decided to make life a little simpler in the future by
generating `template-haskell.cabal` with autoconf.

adam authored 6 years ago and Ben Gamari committed 6 years ago

Also updates the windows gitlab ci to use the new configure variables.

Peter Trommler authored 6 years ago and Ben Gamari committed 6 years ago

Support for Mac OS X on PowerPC has been dropped by Apple years ago. We
follow suit and remove PowerPC support for Darwin.

Fixes #16106.

Alec Theriault authored 6 years ago and Ben Gamari committed 6 years ago

Fix a bug from cb882fc9. Without the
comma, all non-diverging codepaths set 'UseLibdw=NO'.

Reviewers: bgamari, nh2

Reviewed By: nh2

Subscribers: rwbarton, erikd, carter

GHC Trac Issues: #15968

Differential Revision: https://phabricator.haskell.org/D5459

Ben Gamari authored 6 years ago and Ben Gamari committed 6 years ago

There's no reason why we need to print the linked files and apparently
ln on OpenBSD doesn't support -v.

Fixes #15946.

Test Plan: Validate

Reviewers: monoidal

Reviewed By: monoidal

Subscribers: rwbarton, erikd, carter

GHC Trac Issues: #15946

Differential Revision: https://phabricator.haskell.org/D5425