Then one is freer to omit upper bounds, as we won't pick
any new entries on Hackage while building hadrian itself.

Given that shake is far from "done" API wise,
and is central component to the build system.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

I'm not sure how this was omitted from the list of supported
architectures.

Sebastian Graf authored 5 years ago and Marge Bot committed 5 years ago

That would be in line with the implementation.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Should finally fix #17255.

Haskeline now depends upon exceptions. See #16752.

Alp Mestanogullari authored 5 years ago and Ben Gamari committed 5 years ago

This addresses #17456 and also fixes the --metrics-file argument that Hadrian
passes to the testsuite driver.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

This took a bit of trial-and-error to get working so it seems worth
having in the tree.

Alp Mestanogullari authored 5 years ago and Marge Bot committed 5 years ago

Before this patch, Hadrian didn't care about the TEST_ENV and
METRICS_FILE environment variables, that the performance testing
infrastructure uses to record perf tests results from CI jobs.

It now looks them up right before running the testsuite driver,
and passes suitable --test-env/--metrics-file arguments when
these environment variables are set.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Fixing #17255.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Use True/False instead of 0/1. This shouldn't be a functional change but
we should be consistent.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Previously `hadrian` would pass `-optc-Werror=unused-but-set-variable`
to all GHC invocations. This was a difference from the make build system
and cause the unregisterised build to fail as the C that GHC produces
contains many unused functions. Drop it from the GHC flags.

Note, however, that the flag is still present in
`Settings.Builders.Common.cWarnings` and therefore will still be applied
during compilation of C sources.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Some of these flags wanted to be passed to .cmm builds as well as C
builds.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

It seems that NOSMP was previously only defined when compiling the
compiler, not the RTS. Fix this.

In addition do some spring-cleaning and make the logic match that of the
Make build system.

Previously we would allow the output from the check of SMP support
introduced by 83655b06 leak to
stdout. Silence this.

See #16873.

Luke Lau authored 5 years ago and Marge Bot committed 5 years ago

It should point to the _build directory, not the source

adam authored 5 years ago and Marge Bot committed 5 years ago

[skip ci]

Jess authored 5 years ago and Marge Bot committed 5 years ago

This commit makes Hadrian use the `-dynamic-too` flag when the current
Flavour's libraryWays contains both vanilla and dynamic, cutting down
the amount of repeated work caused by separate compilation of dynamic
and static files. It does this for the basic case where '.o' and
'.dyn_o' files are built with one command, but does not generalise to
cases like '.prof_o' and '.prof_dyn_o'.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

See #16873.

Andreas Klebinger authored 5 years ago and Marge Bot committed 5 years ago

cmd uses RawCommand which uses Windows semantics to find the executable
which sometimes seems to fail for unclear reasons.

If we invoke ghc via bash then bash will find the ghc executable and
the issue goes away.

Stefan Schulze Frielinghaus authored 5 years ago and Marge Bot committed 5 years ago

This patch adds support for the s390x architecture for the LLVM code
generator. The patch includes a register mapping of STG registers onto
s390x machine registers which enables a registerised build.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Also refactor things a bit to eliminate repetition.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Fixes #17351.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

This is a very cheap job and can catch a number of "easy" failure modes
(e.g. missing imports in the compiler). Let's run it first.

John Ericson authored 5 years ago and Marge Bot committed 5 years ago

 - No need to distinguish between gcc-llvm and clang. First of all,
   gcc-llvm is quite old and surely unmaintained by now. Second of all,
   none of the code actually care about that distinction!

   Now, it does make sense to consider C multiple frontends for LLVMs in
   the form of clang vs clang-cl (same clang, yes, but tweaked
   interface). But this is better handled in terms of "gccish vs
   mvscish" and "is LLVM", yielding 4 combinations. Therefore, I don't
   think it is useful saving the existing code for that.

 - Get the remaining CC_LLVM_BACKEND, and also TABLES_NEXT_TO_CODE in
   mk/config.h the normal way, rather than hacking it post-hoc. No point
   keeping these special cases around for now reason.

 - Get rid of hand-rolled `die` function and just use `AC_MSG_ERROR`.

 - Abstract check + flag override for unregisterised and tables next to
   code.

Oh, and as part of the above I also renamed/combined some variables
where it felt appropriate.

 - GccIsClang -> CcLlvmBackend. This is for `AC_SUBST`, like the other
 Camal case ones. It was never about gcc-llvm, or Apple's renamed clang,
 to be clear.

 - llvm_CC_FLAVOR -> CC_LLVM_BACKEND. This is for `AC_DEFINE`, like the
 other all-caps snake case ones. llvm_CC_FLAVOR was just silly
 indirection *and* an odd name to boot.

Stefan Schulze Frielinghaus authored 5 years ago and Marge Bot committed 5 years ago

Fixes #17286.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

To avoid polluting the macro namespace

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

This ensures that all GHC flags are documented during the documentation
build.

Fixes #17315.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

This ensure that it blurts an error on missing references.

John Ericson authored 5 years ago and Marge Bot committed 5 years ago

You can always just not use or even build `iserv`. I don't think the
maintenance cost of the CPP is worth...I can't even tell what the
benefit is.

John Ericson authored 5 years ago and Marge Bot committed 5 years ago

They are only used in a file we construct directly, so just skip CPP.