• Ben Gamari's avatar
    TcTypeable: Don't use bogus fingerprints when suppress-uniques is enabled · 786d528e
    Ben Gamari authored
    Previously the Typeable implementation would intentionally create TyCon
    representations with bogus fingerprints to avoid fingerprints (which may
    change often) from leaking into test output. As pointed out by Richard
    in #10376 this is very bad as simply enabling a debug flag,
    `-dsuppress-uniques`, completely breaks the soundness of `Typeable`!
    
    This patch removes this behavior and replaces it with logic in the
    testsuite driver to filter out spurious changes due to Typeable
    representations.
    
    Test Plan: Validate
    
    Reviewers: austin, simonpj, goldfire
    
    Reviewed By: goldfire
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D1629
    
    GHC Trac Issues: #10376
    786d528e
T8274.stdout 803 Bytes