Skip to content
  • Thomas Miedema's avatar
    Pretty: improving the space/time performance of vcat, hsep, hcat (#10735) · f903949b
    Thomas Miedema authored
    After 5d57087e ("Pretty: fix a broken
    invariant"), T3294 showed 50% more max_bytes_used (#3294). After this
    commit, max_bytes_used is back to what it was before, and the test
    passes again.
    
    This is a backport of a bug fix by Benedikt Huber (#2393), from commit
    1e50748beaa4bd2281d323b18ea51c786bba04a1 in the pretty library.
    
    From https://mail.haskell.org/pipermail/libraries/2008-June/009991.html:
    
        vcat (hsep,cat) is implemented in an unneccessarily strict way.
        We only get some output after all of vcat's arguments are evaluated
        and checked against being Empty.
        This can be improved by only checking the right argument of foldr
        against being Empty, and
        then applying an Empty-filter on the resulting Doc. Space improvement
        is obvious.
        The microbenchmark (code.haskell.org/~bhuber/Text/PrettyPrint/
        HughesPJPerfCheck.hs) suggests that
        the improvements in time are remarkable too.
    f903949b