Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
GHC
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Alexander Kaznacheev
GHC
Commits
c5b92fbf
Commit
c5b92fbf
authored
13 years ago
by
David Terei
Committed by
Ian Lynagh
13 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Doc wibble
parent
25ec1677
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
compiler/rename/RnNames.lhs
+9
-7
9 additions, 7 deletions
compiler/rename/RnNames.lhs
with
9 additions
and
7 deletions
compiler/rename/RnNames.lhs
+
9
−
7
View file @
c5b92fbf
...
@@ -60,12 +60,14 @@ and packages. Doing this without caching any trust information would be very
...
@@ -60,12 +60,14 @@ and packages. Doing this without caching any trust information would be very
slow as we would need to touch all packages and interface files a module depends
slow as we would need to touch all packages and interface files a module depends
on. To avoid this we make use of the property that if a modules Safe Haskell
on. To avoid this we make use of the property that if a modules Safe Haskell
mode changes, this triggers a recompilation from that module in the dependcy
mode changes, this triggers a recompilation from that module in the dependcy
graph. So we can just worry mostly about direct imports. There is one trust
graph. So we can just worry mostly about direct imports.
property that can change for a package though without recompliation being
triggered, package trust. So we must check that all packages a module
There is one trust property that can change for a package though without
tranitively depends on to be trusted are still trusted when we are compiling
recompliation being triggered: package trust. So we must check that all
this module (as due to recompilation avoidance some modules below may not be
packages a module tranitively depends on to be trusted are still trusted when
considered trusted any more without recompilation being triggered).
we are compiling this module (as due to recompilation avoidance some modules
below may not be considered trusted any more without recompilation being
triggered).
We handle this by augmenting the existing transitive list of packages a module M
We handle this by augmenting the existing transitive list of packages a module M
depends on with a bool for each package that says if it must be trusted when the
depends on with a bool for each package that says if it must be trusted when the
...
@@ -110,7 +112,7 @@ haskell at all and simply imports B, should A inherit all the the trust
...
@@ -110,7 +112,7 @@ haskell at all and simply imports B, should A inherit all the the trust
requirements from B? Should A now also require that a package p is trusted since
requirements from B? Should A now also require that a package p is trusted since
B required it?
B required it?
We currently say no but
I
saying yes also makes sense. The difference is, if a
We currently say no but saying yes also makes sense. The difference is, if a
module M that doesn't use Safe Haskell imports a module N that does, should all
module M that doesn't use Safe Haskell imports a module N that does, should all
the trusted package requirements be dropped since M didn't declare that it cares
the trusted package requirements be dropped since M didn't declare that it cares
about Safe Haskell (so -XSafe is more strongly associated with the module doing
about Safe Haskell (so -XSafe is more strongly associated with the module doing
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment