Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
GHC
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Alexander Kaznacheev
GHC
Commits
dde20959
Commit
dde20959
authored
10 years ago
by
Ben Gamari
Browse files
Options
Downloads
Patches
Plain Diff
Fix "CPP directive" in comment
parent
32c4e7a4
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
compiler/codeGen/StgCmmClosure.hs
+6
-6
6 additions, 6 deletions
compiler/codeGen/StgCmmClosure.hs
with
6 additions
and
6 deletions
compiler/codeGen/StgCmmClosure.hs
+
6
−
6
View file @
dde20959
...
...
@@ -778,12 +778,12 @@ Note [Black-holing non-updatable thunks]
=========================================
We cannot black-hole non-updatable thunks otherwise we run into issues like
#10414. A single-entry (non-updatable) thunk can actually be entered more
than
once in a parallel program, if work is duplicated by two threads both
entering
the same updatable thunk before the other has blackholed it. So, we
must not
eagerly blackhole non-updatable thunks, or the second thread to enter
one will
become blocked indefinitely. (They are not blackholed by lazy
blackholing
either, since they have no associated update frame.)
Trac
#10414. A single-entry (non-updatable) thunk can actually be entered more
than
once in a parallel program, if work is duplicated by two threads both
entering
the same updatable thunk before the other has blackholed it. So, we
must not
eagerly blackhole non-updatable thunks, or the second thread to enter
one will
become blocked indefinitely. (They are not blackholed by lazy
blackholing
either, since they have no associated update frame.)
For instance, let's consider the following value (in pseudo-Core, example due to
Reid Barton),
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment