add -th-file which generates a th.hs file
Summary: see Trac #8624 similar functionality is now available with -ddump-to-file -ddump-splices However, users are already accustomed to -ddump-splices having a particular format, and this format is not completely valid code The goal of -th-file is to dump valid Haskell code Additionally, the convention of -ddump-to-file is to name the file after the flag, so the file is .dump-splices Given that the goal of the new flag is to generate valid Haskell, The extension should be .hs Additionally, -ddump-to-file effects all other dump flags Test Plan: look at the output of using the -th-file flag and compare it to the output of using -ddump-to-file and -ddump-splices I want to add test cases, but just need some pointers on getting started there Reviewers: thomie, goldfire, simonpj, austin Reviewed By: simonpj, austin Subscribers: thomie, carter Differential Revision: https://phabricator.haskell.org/D518 GHC Trac Issues: #8624 (cherry picked from commit 07ace5c2) Conflicts: docs/users_guide/7.12.1-notes.xml
Showing
- .gitignore 8 additions, 0 deletions.gitignore
- compiler/main/DynFlags.hs 4 additions, 0 deletionscompiler/main/DynFlags.hs
- compiler/main/ErrUtils.hs 2 additions, 1 deletioncompiler/main/ErrUtils.hs
- compiler/rename/RnSplice.hs 55 additions, 8 deletionscompiler/rename/RnSplice.hs
- compiler/typecheck/TcRnDriver.hs 7 additions, 4 deletionscompiler/typecheck/TcRnDriver.hs
- compiler/typecheck/TcRnMonad.hs 4 additions, 7 deletionscompiler/typecheck/TcRnMonad.hs
- compiler/typecheck/TcSplice.hs 53 additions, 10 deletionscompiler/typecheck/TcSplice.hs
- compiler/typecheck/TcSplice.hs-boot 13 additions, 1 deletioncompiler/typecheck/TcSplice.hs-boot
- docs/users_guide/7.10.1-notes.xml 17 additions, 0 deletionsdocs/users_guide/7.10.1-notes.xml
- docs/users_guide/flags.xml 6 additions, 0 deletionsdocs/users_guide/flags.xml
- docs/users_guide/glasgow_exts.xml 39 additions, 3 deletionsdocs/users_guide/glasgow_exts.xml
- testsuite/tests/indexed-types/should_fail/T8129.stdout 0 additions, 1 deletiontestsuite/tests/indexed-types/should_fail/T8129.stdout
- testsuite/tests/th/Makefile 6 additions, 0 deletionstestsuite/tests/th/Makefile
- testsuite/tests/th/T3319.stderr 1 addition, 2 deletionstestsuite/tests/th/T3319.stderr
- testsuite/tests/th/T3600.stderr 1 addition, 2 deletionstestsuite/tests/th/T3600.stderr
- testsuite/tests/th/T5217.stderr 1 addition, 2 deletionstestsuite/tests/th/T5217.stderr
- testsuite/tests/th/T5290.stderr 1 addition, 2 deletionstestsuite/tests/th/T5290.stderr
- testsuite/tests/th/T5700.stderr 1 addition, 2 deletionstestsuite/tests/th/T5700.stderr
- testsuite/tests/th/T5883.stderr 1 addition, 2 deletionstestsuite/tests/th/T5883.stderr
- testsuite/tests/th/T5984.stderr 2 additions, 4 deletionstestsuite/tests/th/T5984.stderr
Loading
Please register or sign in to comment