Skip to content
Snippets Groups Projects
  1. Jun 27, 2019
  2. Jun 26, 2019
  3. Jun 25, 2019
  4. Jun 24, 2019
  5. Jun 23, 2019
    • Ryan Scott's avatar
      Refactor UnliftedNewtypes-relation kind signature validity checks · 9bbcc3be
      Ryan Scott authored and Marge Bot's avatar Marge Bot committed
      This fixes three infelicities related to the programs that are
      (and aren't) accepted with `UnliftedNewtypes`:
      
      * Enabling `UnliftedNewtypes` would permit newtypes to have return
        kind `Id Type`, which had disastrous results (i.e., GHC panics).
      * Data family declarations ending in kind `TYPE r` (for some `r`)
        weren't being accepted if `UnliftedNewtypes` wasn't enabled,
        despite the GHC proposal specifying otherwise.
      * GHC wasn't warning about programs that _would_ typecheck if
        `UnliftedNewtypes` were enabled in certain common cases.
      
      As part of fixing these issues, I factored out the logic for checking
      all of the various properties about data type/data family return
      kinds into a single `checkDataKindSig` function. I also cleaned up
      some of the formatting in the existing error message that gets
      thrown.
      
      Fixes #16821, fixes #16827, and fixes #16829.
      9bbcc3be
    • Ben Gamari's avatar
      ghci: Load static objects in batches · 5a502cd1
      Ben Gamari authored and Marge Bot's avatar Marge Bot committed
      Previously in the case where GHC was dynamically linked we would load
      static objects one-by-one by linking each into its own shared object and
      dlopen'ing each in order. However, this meant that the link would fail
      in the event that the objects had cyclic symbol dependencies.
      
      Here we fix this by merging each "run" of static objects into a single
      shared object and loading this.
      
      Fixes #13786 for the case where GHC is dynamically linked.
      5a502cd1
    • Ben Gamari's avatar
      testsuite: Test for #13786 · ade3db53
      Ben Gamari authored and Marge Bot's avatar Marge Bot committed
      ade3db53
  6. Jun 22, 2019
  7. Jun 21, 2019
    • Ben Gamari's avatar
      linker: Disable code unloading · 49fff41d
      Ben Gamari authored and Marge Bot's avatar Marge Bot committed
      As noted in #16841, there are currently a variety of bugs in the
      unloading logic. These only affect Windows since code unloading is
      disabled on Linux, where we build with `GhcDynamic=YES` by default.
      
      In the interest of getting the tree green on Windows disable code
      unloading until the issues are resolved.
      49fff41d
    • Ben Gamari's avatar
      testsuite: Mark T15633a and T15633b as fragile on Windows · 84900724
      Ben Gamari authored and Marge Bot's avatar Marge Bot committed
      As noted in #16813, these tests seem to be fragile on Windows.
      84900724
Loading