changelog.md · master · Alexandre R. Baldé / containers · GitLab

Due to a large amount of spam we do not allow new users to create repositories, they are "external" users. If you are a new user and want to create a repository, for example for forking GHC, open a new issue on ghc/ghc using the "get-verified" issue template

Jan 21, 2019

Fix Foldable instance for IntMap (fixes #579) (#593) · 4bd9f7ad

Matt Renaud authored Jan 21, 2019

* Fix Foldable instance for IntMap.

As reported in https://github.com/haskell/containers/issues/579 the Foldable
instance for IntMap is unlawful and internally inconsistent. This was caused as
a result of the internal representation used by IntMap.

More specifically, `fold`, `foldMap`, and `traverse` (via `traverseWithKey`)
always placed positively keyed entries before negative keyed ones. To fix this
we need to check to see if the mask is positive or negative.

Tested by adding new property tests, verifying they failed with the
implementation at HEAD, and then passed after the changes.

4bd9f7ad

Fix Foldable instance for IntMap (fixes #579) (#593)

Matt Renaud authored Jan 21, 2019

* Fix Foldable instance for IntMap.

As reported in https://github.com/haskell/containers/issues/579 the Foldable
instance for IntMap is unlawful and internally inconsistent. This was caused as
a result of the internal representation used by IntMap.

More specifically, `fold`, `foldMap`, and `traverse` (via `traverseWithKey`)
always placed positively keyed entries before negative keyed ones. To fix this
we need to check to see if the mask is positive or negative.

Tested by adding new property tests, verifying they failed with the
implementation at HEAD, and then passed after the changes.

To find the state of this project's repository at the time of any of these versions, check out the tags.