-  
 - Downloads
 
x86 codegen: don't generate location comments
The following source snippet 'module A where x */* y = 42'
when being compiled with '-g' option emits syntactically
invalid comment for GNU as:
    .text
        .align 8
        .loc 1 3 1 /* */* */
Fixed by not emitting comments at all. We already suppress
all asm comments in 'X86/Ppr.hs'.
Signed-off-by: 
Sergei Trofimovich <siarheit@google.com>
Test Plan: added test and check it works
Reviewers: scpmw, simonmar, austin, bgamari
Reviewed By: simonmar
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D1386
GHC Trac Issues: #10667
Showing         
- compiler/nativeGen/X86/Ppr.hs 2 additions, 3 deletionscompiler/nativeGen/X86/Ppr.hs
 - testsuite/tests/codeGen/should_compile/T10667.hs 6 additions, 0 deletionstestsuite/tests/codeGen/should_compile/T10667.hs
 - testsuite/tests/codeGen/should_compile/all.T 1 addition, 0 deletionstestsuite/tests/codeGen/should_compile/all.T
 
Loading
Please register or sign in to comment