• Edward Z. Yang's avatar
    Implement -hide-all-plugin-packages and -plugin-package(-id), fixing #11244 · 1faf1fca
    Edward Z. Yang authored
    
    
    Summary:
    The basic idea is that we have a new set of "exposed modules"
    which are /only/ used for plugins, i.e. -fplugin Foo and
    --frontend Foo.  You can interact with this namespace
    using the flags -plugin-package-id and -plugin-package.
    By default, this namespace contains all modules in the
    user namespace (as before), but you can toggle that using
    -hide-all-plugin-packages.
    
    There is one nasty hack: GhcMake respects -fplugin in
    GHC_OPTIONS to make local plugins work correctly.  It also
    bails out of you have an import of a module which doesn't
    exist locally or in the package database.  The upshot is
    that we need to be sure to check in the plugin modules
    too, so we don't give a spurious failure when a plugin
    is in the plugin namespace but not the main namespace.
    A better way to fix this would be to distinguish between
    plugin and normal dependencies in ModSummary.
    
    I cheated a little and tweaked a few existing plugins
    tests to exercise the new code paths.
    
    TODO: Documentation
    Signed-off-by: default avatarEdward Z. Yang <ezyang@cs.stanford.edu>
    
    Test Plan: validate
    
    Reviewers: bgamari, austin, simonpj, duncan
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D1661
    
    GHC Trac Issues: #11244
    1faf1fca
UI.hs 137 KB