• thomie's avatar
    Delete FastBool · 3452473b
    thomie authored
    This reverses some of the work done in Trac #1405, and assumes GHC is
    smart enough to do its own unboxing of booleans now.
    
    I would like to do some more performance measurements, but the code
    changes can be reviewed already.
    
    Test Plan:
    With a perf build:
    ./inplace/bin/ghc-stage2 nofib/spectral/simple/Main.hs -fforce-recomp
    +RTS -t --machine-readable
    
    before:
    ```
      [("bytes allocated", "1300744864")
      ,("num_GCs", "302")
      ,("average_bytes_used", "8811118")
      ,("max_bytes_used", "24477464")
      ,("num_byte_usage_samples", "9")
      ,("peak_megabytes_allocated", "64")
      ,("init_cpu_seconds", "0.001")
      ,("init_wall_seconds", "0.001")
      ,("mutator_cpu_seconds", "2.833")
      ,("mutator_wall_seconds", "4.283")
      ,("GC_cpu_seconds", "0.960")
      ,("GC_wall_seconds", "0.961")
      ]
    ```
    
    after:
    ```
      [("bytes allocated", "1301088064")
      ,("num_GCs", "310")
      ,("average_bytes_used", "8820253")
      ,("max_bytes_used", "24539904")
      ,("num_byte_usage_samples", "9")
      ,("peak_megabytes_allocated", "64")
      ,("init_cpu_seconds", "0.001")
      ,("init_wall_seconds", "0.001")
      ,("mutator_cpu_seconds", "2.876")
      ,("mutator_wall_seconds", "4.474")
      ,("GC_cpu_seconds", "0.965")
      ,("GC_wall_seconds", "0.979")
      ]
    ```
    
    CPU time seems to be up a bit, but I'm not sure. Unfortunately CPU time
    measurements are rather noisy.
    
    Reviewers: austin, bgamari, rwbarton
    
    Subscribers: nomeata
    
    Differential Revision: https://phabricator.haskell.org/D1143
    
    GHC Trac Issues: #1405
    3452473b
Regs.hs 7.32 KB