Skip to content
Snippets Groups Projects
Select Git revision
20 results
Blame Permalink
Forked from Glasgow Haskell Compiler / GHC
Source project has a limited visibility.
  • Ben Gamari's avatar
    e2b60be8
    rts: Consolidate RtsSymbols from libc · e2b60be8
    Ben Gamari authored and Marge Bot's avatar Marge Bot committed 
    Previously (9ebda74e) `environ` was
added to `RtsSymbols` to ensure that environment was correctly
propagated when statically linking. However, this introduced #20577
since platforms are inconsistent in whether they provide a prototype for
`environ`. I fixed this by providing a prototype but while doing so
dropped symbol-table entry, presumably thinking that it was redundant
due to the entry in the mingw-specific table.

Here I reintroduce the symbol table entry for `environ` and move libc
symbols shared by Windows and Linux into a new macro,
`RTS_LIBC_SYMBOLS`, avoiding this potential confusion.
    e2b60be8
    History
    rts: Consolidate RtsSymbols from libc
    Ben Gamari authored and Marge Bot's avatar Marge Bot committed 
    Previously (9ebda74e) `environ` was
added to `RtsSymbols` to ensure that environment was correctly
propagated when statically linking. However, this introduced #20577
since platforms are inconsistent in whether they provide a prototype for
`environ`. I fixed this by providing a prototype but while doing so
dropped symbol-table entry, presumably thinking that it was redundant
due to the entry in the mingw-specific table.

Here I reintroduce the symbol table entry for `environ` and move libc
symbols shared by Windows and Linux into a new macro,
`RTS_LIBC_SYMBOLS`, avoiding this potential confusion.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.