Fix abort and import lib search on Windows
Summary: Apparently `sysErrorBelch` doesn't terminate the program anymore making previously unreachable code now execute. If a dll is not found the error message we return needs to be a heap value. Secondly also allow the pattern `lib<name>` to be allowed for finding an import library with the name `lib<name>.dll.a`. Test Plan: ./validate, new tests T13082_good and T13082_fail Reviewers: austin, RyanGlScott, hvr, erikd, simonmar, bgamari Reviewed By: RyanGlScott, bgamari Subscribers: thomie, #ghc_windows_task_force Differential Revision: https://phabricator.haskell.org/D2941 GHC Trac Issues: #13082
Showing
- compiler/ghci/Linker.hs 3 additions, 1 deletioncompiler/ghci/Linker.hs
- rts/linker/PEi386.c 3 additions, 2 deletionsrts/linker/PEi386.c
- testsuite/tests/rts/T13082/Makefile 15 additions, 0 deletionstestsuite/tests/rts/T13082/Makefile
- testsuite/tests/rts/T13082/T13082_fail.stderr 3 additions, 0 deletionstestsuite/tests/rts/T13082/T13082_fail.stderr
- testsuite/tests/rts/T13082/T13082_good.stdout 1 addition, 0 deletionstestsuite/tests/rts/T13082/T13082_good.stdout
- testsuite/tests/rts/T13082/all.T 11 additions, 0 deletionstestsuite/tests/rts/T13082/all.T
- testsuite/tests/rts/T13082/main.hs 5 additions, 0 deletionstestsuite/tests/rts/T13082/main.hs
Loading
Please register or sign in to comment