Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
GHC
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
sheaf
GHC
Commits
fb1d2cc9
Commit
fb1d2cc9
authored
11 years ago
by
Austin Seipp
Browse files
Options
Downloads
Patches
Plain Diff
Revert "comments"
This reverts commit
9026c77a
.
parent
e734c189
Loading
Loading
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
compiler/codeGen/StgCmmLayout.hs
+0
-27
0 additions, 27 deletions
compiler/codeGen/StgCmmLayout.hs
with
0 additions
and
27 deletions
compiler/codeGen/StgCmmLayout.hs
+
0
−
27
View file @
fb1d2cc9
...
...
@@ -188,7 +188,6 @@ slowCall fun stg_args
" with pat "
++
unpackFS
rts_fun
)
return
r
-- Note [avoid intermediate PAPs]
let
n_args
=
length
stg_args
if
n_args
>
arity
&&
optLevel
dflags
>=
2
then
do
...
...
@@ -225,32 +224,6 @@ slowCall fun stg_args
return
r
-- Note [avoid intermediate PAPs]
--
-- A slow call which needs multiple generic apply patterns will be
-- almost guaranteed to create one or more intermediate PAPs when
-- applied to a function that takes the correct number of arguments.
-- We try to avoid this situation by generating code to test whether
-- we are calling a function with the correct number of arguments
-- first, i.e.:
--
-- if (TAG(f) != 0} { // f is not a thunk
-- if (f->info.arity == n) {
-- ... make a fast call to f ...
-- }
-- }
-- ... otherwise make the slow call ...
--
-- We *only* do this when the call requires multiple generic apply
-- functions, which requires pushing extra stack frames and probably
-- results in intermediate PAPs. (I say probably, because it might be
-- that we're over-applying a function, but that seems even less
-- likely).
--
-- This very rarely applies, but if it does happen in an inner loop it
-- can have a severe impact on performance (#6084).
--------------
direct_call
::
String
->
Convention
-- e.g. NativeNodeCall or NativeDirectCall
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment