Forked from
Glasgow Haskell Compiler / GHC
18182 commits behind, 209 commits ahead of the upstream repository.
Zejun Wu
authored
Summary: Encountered assembly error due to undefined label `.LcaDcU_info_end` for following code generated by `pprFrameProc`: ``` .Lsat_sa8fp{v}_info_fde_end: .long .Lblock{v caDcU}_info_fde_end-.Lblock{v caDcU}_info_fde .Lblock{v caDcU}_info_fde: .long _nbHlD-.Lsection_frame .quad block{v caDcU}_info-1 .quad .Lblock{v caDcU}_info_end-block{v caDcU}_info+1 .byte 1 ``` This diff fixed the error. Test Plan: ./validate Also the case where we used to have assembly error is now fixed. Unfortunately, I have limited insight here and cannot get a small enough repro or test case for this. Ben says: > I think I see: Previously we only produced end symbols for the info > tables of top-level procedures. However, blocks within a procedure may > also have info tables, we will dutifully generate debug information for > and consequently we get undefined symbols. Reviewers: simonmar, scpmw, last_g, bgamari Reviewed By: bgamari Subscribers: rwbarton, carter Differential Revision: https://phabricator.haskell.org/D5246 (cherry picked from commit cf961dcf5ebc26cbd960196ba387736334088303)
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
Name | Last commit | Last update |
---|---|---|
.. | ||
Dwarf | ||
PPC | ||
RegAlloc | ||
SPARC | ||
X86 | ||
AsmCodeGen.hs | ||
CPrim.hs | ||
Dwarf.hs | ||
Format.hs | ||
Instruction.hs | ||
NCG.h | ||
NCGMonad.hs | ||
NOTES | ||
PIC.hs | ||
PprBase.hs | ||
Reg.hs | ||
RegClass.hs | ||
TargetReg.hs |