Skip to content
Snippets Groups Projects
This project is mirrored from https://gitlab.haskell.org/ghc/ghc.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer or owner.
Last successful update .
  1. Nov 26, 2023
    • Alan Zimmerman's avatar
      EPA: Remove EpAnnNotUsed · 7902ebf8
      Alan Zimmerman authored and Marge Bot's avatar Marge Bot committed
      We no longer need the EpAnnNotUsed constructor for EpAnn, as we can
      represent an unused annotation with an anchor having a EpaDelta of
      zero, and empty comments and annotations.
      
      This simplifies code handling annotations considerably.
      
      Updates haddock submodule
      
      Metric Increase:
          parsing001
      7902ebf8
    • Vladislav Zavialov's avatar
      Add name for -Wdeprecated-type-abstractions (#24154) · 3ede659d
      Vladislav Zavialov authored and Marge Bot's avatar Marge Bot committed
      This warning had no name or flag and was triggered unconditionally.
      Now it is part of -Wcompat.
      3ede659d
  2. Nov 24, 2023
    • Alan Zimmerman's avatar
      EPA: Remove parenthesizeHsType · 34d86315
      Alan Zimmerman authored and Marge Bot's avatar Marge Bot committed
      This is called from PostProcess.hs, and adds spurious parens.
      With the looser version of exact printing we had before we could
      tolerate this, as they would be swallowed by the original at the same
      place.
      
      But with the next change (remove EpAnnNotUsed) they result in
      duplicates in the output.
      
      For Darwin build:
      
      Metric Increase:
          MultiLayerModulesTH_OneShot
      34d86315
    • Andreas Klebinger's avatar
      Fix FMA primops generating broken assembly on x86. · fa576eb8
      Andreas Klebinger authored and Marge Bot's avatar Marge Bot committed
      `genFMA3Code` assumed that we had to take extra precations to avoid overwriting
      the result of `getNonClobberedReg`. One of these special cases caused a bug resulting
      in broken assembly.
      
      I believe we don't need to hadle these cases specially at all, which means this MR simply
      deletes the special cases to fix the bug.
      
      Fixes #24160
      fa576eb8
  3. Nov 23, 2023
    • Alan Zimmerman's avatar
      EPA: empty tup_tail has noAnn · d2733a05
      Alan Zimmerman authored and Marge Bot's avatar Marge Bot committed
      In Parser.y, the tup_tail rule had the following option
                | {- empty -} %shift   { return [Left noAnn] }
      
      Once this works through PostProcess.hs, it means we add an extra
      Missing constructor if the last item was a comma.
      
      Change the annotation type to a Bool to indicate this, and use the
      EpAnn Anchor for the print location for the others.
      d2733a05
    • BinderDavid's avatar
      Unify the hpc testsuites · 121c9ab7
      BinderDavid authored and Marge Bot's avatar Marge Bot committed
      The hpc testsuite was split between testsuite/tests/hpc
      and the submodule libraries/hpc/test. This commit unifies
      the two testsuites in the GHC repository in the directory
      testsuite/tests/hpc.
      121c9ab7
  4. Nov 22, 2023
  5. Nov 21, 2023
  6. Nov 20, 2023
  7. Nov 18, 2023
    • Alan Zimmerman's avatar
      EPA: Replace Monoid with NoAnn · 615441ef
      Alan Zimmerman authored and Marge Bot's avatar Marge Bot committed
      Remove the final Monoid instances in the exact print infrastructure.
      
      For Windows CI
      
      Metric Decrease:
          T5205
      615441ef
    • Sven Tennie's avatar
      AArch64: Remove unused instructions · 856e0a4e
      Sven Tennie authored and Marge Bot's avatar Marge Bot committed
      As these aren't ever emitted, we don't even know if they work or will
      ever be used. If one of them is needed in future, we may easily re-add
      it.
      
      Deleted instructions are:
      - CMN
      - ANDS
      - BIC
      - BICS
      - EON
      - ORN
      - ROR
      - TST
      - STP
      - LDP
      - DMBSY
      856e0a4e
  8. Nov 17, 2023
  9. Nov 16, 2023
    • Krzysztof Gogolewski's avatar
      Fix IPE test · 3e606230
      Krzysztof Gogolewski authored and Marge Bot's avatar Marge Bot committed
      A helper function was defined in a different module than used.
      To reproduce: ./hadrian/build test --test-root-dirs=testsuite/tests/rts/ipe
      3e606230
    • Sylvain Henry's avatar
      Fix unusable units and module reexport interaction (#21097) · cee81370
      Sylvain Henry authored and Marge Bot's avatar Marge Bot committed
      This commit fixes an issue with ModUnusable introduced in df0f148f.
      
      In mkUnusableModuleNameProvidersMap we traverse the list of unusable
      units and generate ModUnusable origin for all the modules they contain:
      exposed modules, hidden modules, and also re-exported modules. To do
      this we have a two-level map:
      
        ModuleName -> Unit:ModuleName (aka Module) -> ModuleOrigin
      
      So for each module name "M" in broken unit "u" we have:
        "M" -> u:M -> ModUnusable reason
      
      However in the case of module reexports we were using the *target*
      module as a key. E.g. if "u:M" is a reexport for "X" from unit "o":
         "M" -> o:X -> ModUnusable reason
      
      Case 1: suppose a reexport without module renaming (u:M -> o:M) from
      unusable unit u:
         "M" -> o:M -> ModUnusable reason
      
      Here it's claiming that the import of M is unusable because a reexport
      from u is unusable. But if unit o isn't unusable we could also have in
      the map:
         "M" -> o:M -> ModOrigin ...
      
      Issue: the Semigroup instance of ModuleOrigin doesn't handle the case
      (ModUnusable <> ModOrigin)
      
      Case 2: similarly we could have 2 unusable units reexporting the same module
      without renaming, say (u:M -> o:M) and (v:M -> o:M) with u and v
      unusable. It gives:
      
        "M" -> o:M -> ModUnusable ... (for u)
        "M" -> o:M -> ModUnusable ... (for v)
      
      Issue: the Semigroup instance of ModuleOrigin doesn't handle the case
      (ModUnusable <> ModUnusable).
      
      This led to #21097, #16996, #11050.
      
      To fix this, in this commit we make ModUnusable track whether the module
      used as key is a reexport or not (for better error messages) and we use
      the re-export module as key. E.g. if "u:M" is a reexport for "o:X" and u
      is unusable, we now record:
      
          "M" -> u:M -> ModUnusable reason reexported=True
      
      So now, we have two cases for a reexport u:M -> o:X:
         - u unusable: "M" -> u:M -> ModUnusable ... reexported=True
         - u usable:   "M" -> o:X -> ModOrigin   ... reexportedFrom=u:M
      
      The second case is indexed with o:X because in this case the Semigroup
      instance of ModOrigin is used to combine valid expositions of a module
      (directly or via reexports).
      
      Note that module lookup functions select usable modules first (those who
      have a ModOrigin value), so it doesn't matter if we add new ModUnusable
      entries in the map like this:
      
        "M" -> {
          u:M -> ModUnusable ... reexported=True
          o:M -> ModOrigin ...
        }
      
      The ModOrigin one will be used. Only if there is no ModOrigin or
      ModHidden entry will the ModUnusable error be printed. See T21097 for an
      example printing several reasons why an import is unusable.
      cee81370
    • Simon Peyton Jones's avatar
      Second fix to #24083 · 2776920e
      Simon Peyton Jones authored and Marge Bot's avatar Marge Bot committed
      My earlier fix turns out to be too aggressive for data/type families
      
      See wrinkle (DTV1) in Note [Disconnected type variables]
      2776920e
    • Krzysztof Gogolewski's avatar
      Document defaulting of RuntimeReps · a6467834
      Krzysztof Gogolewski authored and Marge Bot's avatar Marge Bot committed
      Fixes #24099
      a6467834
  10. Nov 15, 2023
    • Alan Zimmerman's avatar
      EPA: splitLHsForAllTyInvis does not return ann · 27981fac
      Alan Zimmerman authored and Marge Bot's avatar Marge Bot committed
      We did not use the annotations returned from splitLHsForAllTyInvis, so
      do not return them.
      27981fac
    • Zubin's avatar
      users-guide: Fix links to libraries from the users-guide. · 2aff2361
      Zubin authored and Marge Bot's avatar Marge Bot committed
      The unit-ids generated in c1a3ecde include the
      package name, so we don't need to explicitly add it to the links.
      
      Fixes #24151
      2aff2361
    • Krzysztof Gogolewski's avatar
      Remove loopy superclass solve mechanism · 99ced73b
      Krzysztof Gogolewski authored and Marge Bot's avatar Marge Bot committed
      Programs with a -Wloopy-superclass-solve warning will now fail with an error.
      
      Fixes #23017
      99ced73b
    • Luite Stegeman's avatar
      JS: Fix missing variable declarations · 2125c176
      Luite Stegeman authored and Marge Bot's avatar Marge Bot committed
      The JStg IR update was missing some local variable declarations
      that were present earlier, causing global variables to be used
      implicitly (or an error in JavaScript strict mode).
      
      This adds the local variable declarations again.
      2125c176
    • Rodrigo Mesquita's avatar
      configure: check target (not build) understands -no_compact_unwind · af261ccd
      Rodrigo Mesquita authored and Marge Bot's avatar Marge Bot committed
      Previously, we were branching on whether the build system was darwin to
      shortcut this check, but we really want to branch on whether the target
      system (which is what we are configuring ld_prog for) is darwin.
      af261ccd
    • Rodrigo Mesquita's avatar
      testsuite: Skip MultiLayerModulesTH_Make on darwin · 929ba2f9
      Rodrigo Mesquita authored and Marge Bot's avatar Marge Bot committed
      The recent toolchain upgrade on darwin machines resulted in the
      MultiLayerModulesTH_Make test metrics varying too much from the
      baseline, ultimately blocking the CI pipelines.
      
      This commit skips the test on darwin to temporarily avoid failures due
      to the environment change in the runners. However, the metrics
      divergence is being investigated still (tracked in #24177)
      929ba2f9
    • Rodrigo Mesquita's avatar
      darwin: Fix single_module is obsolete warning · e6c803f7
      Rodrigo Mesquita authored and Marge Bot's avatar Marge Bot committed
      In XCode 15's linker, -single_module is the default and otherwise
      passing it as a flag results in a warning being raised:
      
          ld: warning: -single_module is obsolete
      
      This patch fixes this warning by, at configure time, determining whether
      the linker supports -single_module (which is likely false for all
      non-darwin linkers, and true for darwin linkers in previous versions of
      macOS), and using that information at runtime to decide to pass or not
      the flag in the invocation.
      
      Fixes #24168
      e6c803f7
    • Rodrigo Mesquita's avatar
      testsuite: Update to LC_ALL=C no longer being ignored in darwin · ce7fe5a9
      Rodrigo Mesquita authored and Marge Bot's avatar Marge Bot committed
      MacOS seems to have fixed an issue where it used to ignore the variable
      `LC_ALL` in program invocations and default to using Unicode.
      
      Since the behaviour seems to be fixed to account for the locale
      variable, we mark tests that were previously broken in spite of it as
      fragile (since they now pass in recent macOS distributions)
      
      See #24161
      ce7fe5a9
    • Rodrigo Mesquita's avatar
      testsuite: Encoding test witnesses recent iconv bug is fragile · c411c431
      Rodrigo Mesquita authored and Marge Bot's avatar Marge Bot committed
      A regression in the new iconv() distributed with XCode 15 and MacOS
      Sonoma causes the test 'encoding004' to fail in the CP936 roundrip.
      
      We mark this test as fragile until this is fixed upstream (rather than
      broken, since previous versions of iconv pass the test)
      
      See #24161
      c411c431
    • Rodrigo Mesquita's avatar
      Suppress duplicate librares linker warning of new macOS linker · e98051a5
      Rodrigo Mesquita authored and Marge Bot's avatar Marge Bot committed
      Fixes #24167
      
      XCode 15 introduced a new linker which warns on duplicate libraries being
      linked. To disable this warning, we pass -Wl,-no_warn_duplicate_libraries as
      suggested by Brad King in CMake issue #25297.
      
      This flag isn't necessarily available to other linkers on darwin, so we must
      only configure it into the CC linker arguments if valid.
      e98051a5
  11. Nov 13, 2023
  12. Nov 12, 2023
Loading