Don't move Capabilities in setNumCapabilities (#8209)
We have various problems with reallocating the array of Capabilities, due to threads in waitForReturnCapability that are already holding a pointer to a Capability. Rather than add more locking to make this safer, I decided it would be easier to ensure that we never move the Capabilities at all. The capabilities array is now an array of pointers to Capabaility. There are extra indirections, but it rarely matters - we don't often access Capabilities via the array, normally we already have a pointer to one. I ran the parallel benchmarks and didn't see any difference.
Showing
- rts/Capability.c 43 additions, 40 deletionsrts/Capability.c
- rts/Capability.h 4 additions, 4 deletionsrts/Capability.h
- rts/Profiling.c 1 addition, 1 deletionrts/Profiling.c
- rts/Proftimer.c 1 addition, 1 deletionrts/Proftimer.c
- rts/RetainerProfile.c 1 addition, 1 deletionrts/RetainerProfile.c
- rts/Schedule.c 35 additions, 52 deletionsrts/Schedule.c
- rts/Stats.c 17 additions, 17 deletionsrts/Stats.c
- rts/Task.c 0 additions, 28 deletionsrts/Task.c
- rts/Task.h 0 additions, 5 deletionsrts/Task.h
- rts/Threads.c 1 addition, 1 deletionrts/Threads.c
- rts/sm/Compact.c 1 addition, 1 deletionrts/sm/Compact.c
- rts/sm/GC.c 22 additions, 28 deletionsrts/sm/GC.c
- rts/sm/Sanity.c 7 additions, 7 deletionsrts/sm/Sanity.c
- rts/sm/Storage.c 5 additions, 5 deletionsrts/sm/Storage.c
Loading
Please register or sign in to comment