Skip to content
  • Matthew Pickering's avatar
    d122e022
    Fix mk_mod_usage_info if the interface file is not already loaded · d122e022
    Matthew Pickering authored and Marge Bot's avatar Marge Bot committed
    In #22217 it was observed that the order modules are compiled in affects
    the contents of an interface file. This was because a module dependended
    on another module indirectly, via a re-export but the interface file for
    this module was never loaded because the symbol was never used in the
    file.
    
    If we decide that we depend on a module then we jolly well ought to
    record this fact in the interface file! Otherwise it could lead to very
    subtle recompilation bugs if the dependency is not tracked and the
    module is updated.
    
    Therefore the best thing to do is just to make sure the file is loaded
    by calling the `loadSysInterface` function.  This first checks the
    caches (like we did before) but then actually goes to find the interface
    on disk if it wasn't loaded.
    
    Fixes #22217
    d122e022
    Fix mk_mod_usage_info if the interface file is not already loaded
    Matthew Pickering authored and Marge Bot's avatar Marge Bot committed
    In #22217 it was observed that the order modules are compiled in affects
    the contents of an interface file. This was because a module dependended
    on another module indirectly, via a re-export but the interface file for
    this module was never loaded because the symbol was never used in the
    file.
    
    If we decide that we depend on a module then we jolly well ought to
    record this fact in the interface file! Otherwise it could lead to very
    subtle recompilation bugs if the dependency is not tracked and the
    module is updated.
    
    Therefore the best thing to do is just to make sure the file is loaded
    by calling the `loadSysInterface` function.  This first checks the
    caches (like we did before) but then actually goes to find the interface
    on disk if it wasn't loaded.
    
    Fixes #22217
Loading