Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
GHC
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
gershomb
GHC
Commits
bd53b488
Commit
bd53b488
authored
7 years ago
by
Andreas Klebinger
Committed by
Ben Gamari
7 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Add info about Github pull requests.
parent
bf83435b
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
HACKING.md
+6
-6
6 additions, 6 deletions
HACKING.md
with
6 additions
and
6 deletions
HACKING.md
+
6
−
6
View file @
bd53b488
...
...
@@ -61,12 +61,12 @@ newly built compiler.
Now, hack on your copy and rebuild (with
`make`
) as necessary.
Then start by making your commits however you want. When you're done, you
'll
need to submit your patch to
[
Phabricator
](
https://phabricator.haskell.org/
)
for
code review. To do so you will need to
[
install Arcanist
](
https://secure.phabricator.com/book/phabricator/article/arcanist/#installing-arcanist
)
,
Phabricator's CLI tool. Once installed, you can submit your work for code review
using
`arc diff`
.
Then start by making your commits however you want. When you're done, you
can submit
a pull request on Github for small changes. For larger changes the patch needs to be
submitted to
[
Phabricator
](
https://phabricator.haskell.org/
)
for code review.
The GHC Trac Wiki has a good summary for the
[
overall process
](
https://ghc.haskell.org/trac/ghc/wiki/WorkingConventions/FixingBugs
)
as well as a guide on
[
how to use Phabricator/arcanist
](
https://ghc.haskell.org/trac/ghc/wiki/Phabricator
)
.
Useful links:
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment