KevinBuhr authored 5 years ago and Marge Bot committed 5 years ago

Package DB directories with trailing separator (provided via
GHC_PACKAGE_PATH or via -package-db) resulted in incorrect calculation of
${pkgroot} substitution variable.  Keep the trailing separator while
resolving as directory or file, but remove it before dropping the last
path component with takeDirectory.

Closes #16360.

chessai authored 6 years ago and Marge Bot committed 5 years ago

Previously log and exp were primitives yet log1p and expm1 were FFI
calls. Fix this non-uniformity.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

As noted in #16741, this test otherwise breaks when `base` is compiled
with `-g`.

Matthew Pickering authored 5 years ago and Marge Bot committed 5 years ago

Previously if you build the `ghc` package then it would has the default
opts and the library opts. This is different behaviour to make where the
library opts are only reserved for things in the `libraries`
subdirectory (I believe)

Fixes #16716

The previous commit reworked things such that the submodule linter would
only run on the head commit. However, the linter only checks the
submodules which are touched by the commits it is asked to lint.
Consequently it would be possible for a bad submodule to sneak through.

Thankfully, we can use the handy CI_COMMIT_BEFORE_SHA attribute to
find the base commit of the push.

There is no notion of a base commit when we aren't checking a merge
request. Just check the HEAD commit.

Previously we were passing `--unshallow` to `git fetch` in the linting
rules to ensure that the base commit which we were linting with respect
to was available. However, this breaks due to GitLab's re-use of
working directories since `git fetch --unshallow` fails on a repository
which is not currently shallow.

Given that `git fetch --unshallow` circumvents the efficiencies provided
by shallow clones anyways, let's just disable them entirely.

There is no documented way to do disable shallow clones but on checking
the GitLab implementation it seems that setting `GIT_DEPTH=0` should do
the trick.

Matthew Pickering authored 5 years ago and Ben Gamari committed 5 years ago

[skip ci]

This should really be caught by the linters! (#16711)

The job script didn't even try to compute the base commit to lint with
respect to.

GitLab creates a shallow clone. However, this means that we may not have
the base commit of an MR when linting, causing `git merge-base` to fail.
Fix this by passing `--unshallow` to `git fetch`, ensuring that we have
the entire history.

Matthew Pickering authored 5 years ago and Ben Gamari committed 5 years ago

Ben disabled them in cd85f8a7 but didn't
say how or why they were broken.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Otherwise navigating to https://ghc.gitlab.haskell.org/ghc will result
in a 404.

Alp Mestanogullari authored 5 years ago and Marge Bot committed 5 years ago

This should fix #16739, where we seem to be getting extra carets in
a test's output because of the gcc that ships with the deb8 image,
whule we're not observing those extra carets in the deb9-based (Make)
jobs.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

As requested in #16750.

Simon Jakobi authored 5 years ago and Marge Bot committed 5 years ago

Previously the `integer-gmp` variant of `isValidNatural` would fail to
detect values `<= maxBound::Word` that were incorrectly encoded using
the `NatJ#` constructor.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Previously createFileLinkUntracked would fail if the symlink already
existed.

Simon Peyton Jones authored 5 years ago and Marge Bot committed 5 years ago

When the canonicaliser rewrites evidence of a Wanted, it
should preserve the ShadowInfo (ctev_nosh) field.  That is,
a WDerive should rewrite to WDerive, and WOnly to WOnly.

Previously we were unconditionally making a WDeriv, thereby
rewriting WOnly to WDeriv.  This bit Nick Frisby (issue #16735)
in the context of his plugin, but we don't have a compact test
case.

The fix is simple, but does involve a bit more plumbing,
to pass the old ShadowInfo around, to use when building
the new Wanted.

John Ericson authored 5 years ago and Marge Bot committed 5 years ago

ghc-pkg and ghc already both needed this. I figure it is better to
deduplicate, especially seeing that changes to one (FreeBSD CPP) didn't
make it to the other.

Additionally in !1090 I make ghc-pkg look up the settings file, which
makes it use the top dir a bit more widely. If that lands, any
difference in the way they find the top dir would be more noticable.

That change also means sharing more code between ghc and ghc-package
(namely the settings file parsing code), so I'd think it better to get
off the slipperly slope of duplicating code now.

Roland Senn authored 5 years ago and Marge Bot committed 5 years ago

`:info Coercible` now outputs the correct section number of the GHCi User's guide together with the secion title.

`:forward x` gives the correct syntax hint.

Matthew Pickering authored 5 years ago and Marge Bot committed 5 years ago

This allows a user to observe how long a sampling period lasts so that
the time taken can be removed from the profiling output.

Fixes #16697

Sebastian Graf authored 5 years ago and Marge Bot committed 5 years ago

The `PmExprEq` business was a huge hack and was at the same time vastly
too powerful and not powerful enough to encode negative term equalities,
i.e. facts of the form "forall y. x ≁ Just y".

This patch introduces the concept of 'refutable shapes': What matters
for the pattern match checker is being able to encode knowledge of the
kind "x can no longer be the literal 5". We encode this knowledge in a
`PmRefutEnv`, mapping a set of newly introduced `PmAltCon`s (which are
just `PmLit`s at the moment) to each variable denoting above
inequalities.

So, say we have `x ≁ 42 ∈ refuts` in the term oracle context and
try to solve an equality like `x ~ 42`. The entry in the refutable
environment will immediately lead to a contradiction.

This machinery renders the whole `PmExprEq` and `ComplexEq` business
unnecessary, getting rid of a lot of (mostly dead) code.

See the Note [Refutable shapes] in TmOracle for a place to start.

Metric Decrease:
    T11195

Andrew Martin authored 5 years ago and Marge Bot committed 5 years ago

[skip ci] Improve the documentation of the CNF primops. In this context, the term "size" is ambiguous and is now avoided. Additionally, the distinction between a CNF and the blocks that comprise it has been emphasize. The vocabulary has been made more consistent with the vocabulary in the C source for CNF.

See #16771

We don't have enough capacity for the two jobs currently.

[skip ci]

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

This fixes a few vestigial references to `settings` left over from !655.
Fixes #16715.

xldenis authored 6 years ago and Marge Bot committed 5 years ago

This commit adds the `:instances` command to ghci following proosal
number 41.

This makes it possible to query which instances are available to a given
type.

The output of this command is all the possible instances with type
variables and constraints instantiated.

Alp Mestanogullari authored 5 years ago and Marge Bot committed 5 years ago

The OSX build failure introduced in 3aa71a22 was due to a change in the
glob we use to collect libffi shared libraries in hadrian/src/Rules/Libffi.hs.
This commit fixes the problem and adds an OSX CI job that builds GHC with
Hadrian, to make sure we don't break it again.

Andrew Martin authored 5 years ago and Marge Bot committed 5 years ago

Use a better strategy for determining the offset applied to foreign function arguments that have an unlifted boxed type. We used to use the type of the argument. We now use the type of the foreign function. Add a test to confirm that the roundtrip conversion between an unlifted boxed type and Any is sound in the presence of a foreign function call.