Skip to content
Snippets Groups Projects
  1. Jul 31, 2017
  2. Jul 30, 2017
  3. Jul 29, 2017
    • Ryan Scott's avatar
      Follow-up to #13887, for promoted infix constructors · 7089dc2f
      Ryan Scott authored
      Summary:
      Correct a couple more spots in the TH pretty-printer by applying the
      appropriate parenthesization for infix names. Fixes #13887 (again).
      
      Test Plan: make test TEST=T13887
      
      Reviewers: austin, bgamari
      
      Subscribers: rwbarton, thomie
      
      GHC Trac Issues: #13887
      
      Differential Revision: https://phabricator.haskell.org/D3802
      7089dc2f
    • Ryan Scott's avatar
      Add regression test for #14055 · f839b9de
      Ryan Scott authored
      f839b9de
    • Richard Eisenberg's avatar
      Fix #14045 by omitting an unnecessary check · d1ef223c
      Richard Eisenberg authored
      Previously, we checked the number of patterns in a data instances
      for all data families whose kind did not end in a kind variable.
      But, of course, undersaturating instances can happen even without
      the kind ending in a kind variable. So I've omitted the arity check.
      Data families aren't as particular about their arity as type families
      are (because data families can be undersaturated). Still, this change
      degrades error messages when instances don't have the right arity;
      now, instead of reporting a simple mismatch in the number of patterns,
      GHC reports kind errors. The new errors are fully accurate, but perhaps
      not as easy to work with. Still, with the new flexibility of allowing
      data family instances with varying numbers of patterns, I don't see
      a better way.
      
      This commit also improves source fidelity in some error messages,
      requiring more changes than really are necessary. But without these
      changes, error messages around mismatched associated instance heads
      were poor.
      
      test cases: indexed-types/should_compile/T14045,
                  indexed-types/should_fail/T14045a
      d1ef223c
    • Sven Tennie's avatar
      Add '<&>' operator to Data.Functor. '<&>' calls '<$>' with flipped arguments. · 9cfabbb5
      Sven Tennie authored and Ben Gamari's avatar Ben Gamari committed
      This was proposed by David Feuer
      (https://mail.haskell.org/pipermail/libraries/2016-August/027293.html)
      and solves #14029.
      
      The implementation is a copy of the '<&>' operator in Control.Lens.Lens.
      
      Add tests for following Data.Functor operators: '<$>', '<&>', '<$' and '$>'.
      
      '<&>' was added for solving #14029. '<$>', '<$' and '$>' were probably
      untested.
      
      Reviewers: austin, hvr, bgamari, RyanGlScott
      
      Reviewed By: RyanGlScott
      
      Subscribers: RyanGlScott, rwbarton, thomie
      
      Differential Revision: https://phabricator.haskell.org/D3800
      9cfabbb5
  4. Jul 28, 2017
  5. Jul 27, 2017
    • Andreas Klebinger's avatar
      Initialize hs_init with UTF8 encoded arguments on Windows. · 7af0b906
      Andreas Klebinger authored and Tamar Christina's avatar Tamar Christina committed
      Summary:
      Get utf8 encoded arguments before we call hs_init and use them
      instead of ignoring hs_init arguments. This reduces differing
      behaviour of the RTS between windows and linux and simplifies
      the code involved.
      
      A few testcases were changed to expect the same result on windows
      as on linux after the changes.
      
      This fixes #13940.
      
      Test Plan: ./validate
      
      Reviewers: austin, hvr, bgamari, erikd, simonmar, Phyx
      
      Subscribers: Phyx, rwbarton, thomie
      
      GHC Trac Issues: #13940
      
      Differential Revision: https://phabricator.haskell.org/D3739
      7af0b906
    • Richard Eisenberg's avatar
      Refactor tcInferApps. · 791947db
      Richard Eisenberg authored
      With the changes caused by the fix to #12369, it is now clearer
      how to rewrite tcInferApps and friends. This should change no
      behavior, but it does clean up a nasty corner of the type checker.
      This commit also removes some uses of substTyUnchecked.
      791947db
Loading