Skip to content
Snippets Groups Projects
Forked from Glasgow Haskell Compiler / GHC
Source project has a limited visibility.
  • Rodrigo Mesquita's avatar
    c6741e72
    Configure -Qunused-arguments instead of hardcoding it · c6741e72
    Rodrigo Mesquita authored and Marge Bot's avatar Marge Bot committed
    When GHC invokes clang, it currently passes -Qunused-arguments to
    discard warnings resulting from GHC using multiple options that aren't
    used.
    
    In this commit, we configure -Qunused-arguments into the Cc options
    instead of checking if the compiler is clang at runtime and hardcoding
    the flag into GHC.
    
    This is part of the effort to centralise toolchain information in
    toolchain target files at configure time with the end goal of a runtime
    retargetable GHC.
    
    This also means we don't need to call getCompilerInfo ever, which
    improves performance considerably (see !10589).
    
    Metric Decrease:
        PmSeriesG
        T10421
        T11303b
        T12150
        T12227
        T12234
        T12425
        T13035
        T13253-spj
        T13386
        T15703
        T16875
        T17836b
        T17977
        T17977b
        T18140
        T18282
        T18304
        T18698a
        T18698b
        T18923
        T20049
        T21839c
        T3064
        T5030
        T5321FD
        T5321Fun
        T5837
        T6048
        T9020
        T9198
        T9872d
        T9961
    c6741e72
    History
    Configure -Qunused-arguments instead of hardcoding it
    Rodrigo Mesquita authored and Marge Bot's avatar Marge Bot committed
    When GHC invokes clang, it currently passes -Qunused-arguments to
    discard warnings resulting from GHC using multiple options that aren't
    used.
    
    In this commit, we configure -Qunused-arguments into the Cc options
    instead of checking if the compiler is clang at runtime and hardcoding
    the flag into GHC.
    
    This is part of the effort to centralise toolchain information in
    toolchain target files at configure time with the end goal of a runtime
    retargetable GHC.
    
    This also means we don't need to call getCompilerInfo ever, which
    improves performance considerably (see !10589).
    
    Metric Decrease:
        PmSeriesG
        T10421
        T11303b
        T12150
        T12227
        T12234
        T12425
        T13035
        T13253-spj
        T13386
        T15703
        T16875
        T17836b
        T17977
        T17977b
        T18140
        T18282
        T18304
        T18698a
        T18698b
        T18923
        T20049
        T21839c
        T3064
        T5030
        T5321FD
        T5321Fun
        T5837
        T6048
        T9020
        T9198
        T9872d
        T9961
Code owners
Assign users and groups as approvers for specific file changes. Learn more.