Skip to content
  • Zubin's avatar
    576f8b7e
    Revert "Apply shellcheck suggestion to SUBST_TOOLDIR" · 576f8b7e
    Zubin authored and Marge Bot's avatar Marge Bot committed
    This reverts commit c82770f5.
    
    The shellcheck suggestion is spurious and results in SUBST_TOOLDIR being a
    no-op. `set` sets positional arguments for bash, but we want to set the variable
    given as the first autoconf argument.
    
    Fixes #24542
    
    Metric decreases because the paths in the settings file are now shorter,
    so we allocate less when we read the settings file.
    
    -------------------------
    Metric Decrease:
        T12425
        T13035
        T9198
    -------------------------
    576f8b7e
    Revert "Apply shellcheck suggestion to SUBST_TOOLDIR"
    Zubin authored and Marge Bot's avatar Marge Bot committed
    This reverts commit c82770f5.
    
    The shellcheck suggestion is spurious and results in SUBST_TOOLDIR being a
    no-op. `set` sets positional arguments for bash, but we want to set the variable
    given as the first autoconf argument.
    
    Fixes #24542
    
    Metric decreases because the paths in the settings file are now shorter,
    so we allocate less when we read the settings file.
    
    -------------------------
    Metric Decrease:
        T12425
        T13035
        T9198
    -------------------------
Loading