Skip to content
Snippets Groups Projects
Forked from Glasgow Haskell Compiler / GHC
5501 commits behind the upstream repository.
  • sheaf's avatar
    28880828
    Typecheck remaining ValArgs in rebuildHsApps · 28880828
    sheaf authored and Marge Bot's avatar Marge Bot committed
    This patch refactors hasFixedRuntimeRep_remainingValArgs, renaming it
    to tcRemainingValArgs. The logic is moved to rebuildHsApps, which
    ensures consistent behaviour across tcApp and quickLookArg1/tcEValArg.
    
    This patch also refactors the treatment of stupid theta for data
    constructors, changing the place we drop stupid theta arguments
    from dsConLike to mkDataConRep (now the datacon wrapper drops these
    arguments).
    
    We decided not to implement PHASE 2 of the FixedRuntimeRep plan for
    these remaining ValArgs. Future directions are outlined on the wiki:
      https://gitlab.haskell.org/ghc/ghc/-/wikis/Remaining-ValArgs
    
    Fixes #21544 and #21650
    28880828
    History
    Typecheck remaining ValArgs in rebuildHsApps
    sheaf authored and Marge Bot's avatar Marge Bot committed
    This patch refactors hasFixedRuntimeRep_remainingValArgs, renaming it
    to tcRemainingValArgs. The logic is moved to rebuildHsApps, which
    ensures consistent behaviour across tcApp and quickLookArg1/tcEValArg.
    
    This patch also refactors the treatment of stupid theta for data
    constructors, changing the place we drop stupid theta arguments
    from dsConLike to mkDataConRep (now the datacon wrapper drops these
    arguments).
    
    We decided not to implement PHASE 2 of the FixedRuntimeRep plan for
    these remaining ValArgs. Future directions are outlined on the wiki:
      https://gitlab.haskell.org/ghc/ghc/-/wikis/Remaining-ValArgs
    
    Fixes #21544 and #21650
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
T21544.hs 645 B