Fix unused-import stuff in a better way
The fix for Trac #10890 in commit 1818b48e, namely Fix incorrect import warnings when methods with identical names are imported was wrong, as demonstrated by the new test T10890_2. It suppressed far too many warnings! This patch fixes the original problem in a different way, by making RdrName.greUsedRdrName a bit cleverer. But this too is not really the Right Thing. I think the Right Thing is to store the /GRE/ in the tcg_used_rdrnames, not the /RdrName/. That would be a lot simpler and more direct. But one step at a time.
Showing
- compiler/basicTypes/RdrName.hs 35 additions, 27 deletionscompiler/basicTypes/RdrName.hs
- compiler/rename/RnNames.hs 7 additions, 21 deletionscompiler/rename/RnNames.hs
- testsuite/tests/module/mod177.stderr 1 addition, 1 deletiontestsuite/tests/module/mod177.stderr
- testsuite/tests/warnings/should_compile/T10890/T10890_2.hs 17 additions, 0 deletionstestsuite/tests/warnings/should_compile/T10890/T10890_2.hs
- testsuite/tests/warnings/should_compile/T10890/T10890_2.stderr 5 additions, 0 deletions...uite/tests/warnings/should_compile/T10890/T10890_2.stderr
- testsuite/tests/warnings/should_compile/T10890/T10890_2A.hs 4 additions, 0 deletionstestsuite/tests/warnings/should_compile/T10890/T10890_2A.hs
- testsuite/tests/warnings/should_compile/T10890/T10890_2B.hs 4 additions, 0 deletionstestsuite/tests/warnings/should_compile/T10890/T10890_2B.hs
- testsuite/tests/warnings/should_compile/T10890/all.T 4 additions, 0 deletionstestsuite/tests/warnings/should_compile/T10890/all.T
Loading
Please register or sign in to comment