Upgrade UniqSet to a newtype
The fundamental problem with `type UniqSet = UniqFM` is that `UniqSet` has a key invariant `UniqFM` does not. For example, `fmap` over `UniqSet` will generally produce nonsense. * Upgrade `UniqSet` from a type synonym to a newtype. * Remove unused and shady `extendVarSet_C` and `addOneToUniqSet_C`. * Use cached unique in `tyConsOfType` by replacing `unitNameEnv (tyConName tc) tc` with `unitUniqSet tc`. Reviewers: austin, hvr, goldfire, simonmar, niteria, bgamari Reviewed By: niteria Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D3146
Showing
- compiler/basicTypes/DataCon.hs 1 addition, 2 deletionscompiler/basicTypes/DataCon.hs
- compiler/basicTypes/NameSet.hs 2 additions, 3 deletionscompiler/basicTypes/NameSet.hs
- compiler/basicTypes/RdrName.hs 2 additions, 1 deletioncompiler/basicTypes/RdrName.hs
- compiler/basicTypes/VarEnv.hs 24 additions, 25 deletionscompiler/basicTypes/VarEnv.hs
- compiler/basicTypes/VarSet.hs 8 additions, 8 deletionscompiler/basicTypes/VarSet.hs
- compiler/cmm/PprC.hs 1 addition, 1 deletioncompiler/cmm/PprC.hs
- compiler/coreSyn/CoreFVs.hs 4 additions, 2 deletionscompiler/coreSyn/CoreFVs.hs
- compiler/coreSyn/CoreSubst.hs 1 addition, 1 deletioncompiler/coreSyn/CoreSubst.hs
- compiler/coreSyn/CoreSyn.hs 2 additions, 2 deletionscompiler/coreSyn/CoreSyn.hs
- compiler/deSugar/DsArrows.hs 11 additions, 10 deletionscompiler/deSugar/DsArrows.hs
- compiler/deSugar/DsUsage.hs 2 additions, 2 deletionscompiler/deSugar/DsUsage.hs
- compiler/ghci/Debugger.hs 5 additions, 5 deletionscompiler/ghci/Debugger.hs
- compiler/ghci/RtClosureInspect.hs 5 additions, 6 deletionscompiler/ghci/RtClosureInspect.hs
- compiler/iface/MkIface.hs 2 additions, 2 deletionscompiler/iface/MkIface.hs
- compiler/llvmGen/LlvmCodeGen/Base.hs 1 addition, 1 deletioncompiler/llvmGen/LlvmCodeGen/Base.hs
- compiler/nativeGen/RegAlloc/Graph/ArchBase.hs 3 additions, 3 deletionscompiler/nativeGen/RegAlloc/Graph/ArchBase.hs
- compiler/nativeGen/RegAlloc/Graph/Main.hs 8 additions, 8 deletionscompiler/nativeGen/RegAlloc/Graph/Main.hs
- compiler/nativeGen/RegAlloc/Graph/Spill.hs 3 additions, 3 deletionscompiler/nativeGen/RegAlloc/Graph/Spill.hs
- compiler/nativeGen/RegAlloc/Graph/SpillClean.hs 3 additions, 3 deletionscompiler/nativeGen/RegAlloc/Graph/SpillClean.hs
- compiler/nativeGen/RegAlloc/Graph/SpillCost.hs 3 additions, 3 deletionscompiler/nativeGen/RegAlloc/Graph/SpillCost.hs
Loading
Please register or sign in to comment