Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
GHC
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Terraform modules
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Reinier Maas
GHC
Commits
d3de8668
Commit
d3de8668
authored
1 year ago
by
Sylvain Henry
Committed by
Marge Bot
1 year ago
Browse files
Options
Downloads
Patches
Plain Diff
JS: don't use isRuntimeRepKindedTy in JS FFI
parent
19216ca5
No related branches found
Branches containing commit
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
compiler/GHC/HsToCore/Foreign/JavaScript.hs
+1
-6
1 addition, 6 deletions
compiler/GHC/HsToCore/Foreign/JavaScript.hs
with
1 addition
and
6 deletions
compiler/GHC/HsToCore/Foreign/JavaScript.hs
+
1
−
6
View file @
d3de8668
...
...
@@ -471,10 +471,6 @@ unboxJsArg arg
Just
arg3_tycon
=
maybe_arg3_tycon
boxJsResult
::
Type
->
DsM
(
Type
,
CoreExpr
->
CoreExpr
)
boxJsResult
result_ty
|
isRuntimeRepKindedTy
result_ty
=
panic
"boxJsResult: runtime rep ty"
-- fixme
-- Takes the result of the user-level ccall:
-- either (IO t),
-- or maybe just t for an side-effect-free call
...
...
@@ -485,7 +481,7 @@ boxJsResult result_ty
-- where t' is the unwrapped form of t. If t is simply (), then
-- the result type will be
-- State# RealWorld -> (# State# RealWorld #)
boxJsResult
::
Type
->
DsM
(
Type
,
CoreExpr
->
CoreExpr
)
boxJsResult
result_ty
|
Just
(
io_tycon
,
io_res_ty
)
<-
tcSplitIOType_maybe
result_ty
-- isIOType_maybe handles the case where the type is a
...
...
@@ -585,7 +581,6 @@ jsResultWrapper
-- E.g. foreign import foo :: Int -> IO T
-- Then resultWrapper deals with marshalling the 'T' part
jsResultWrapper
result_ty
|
isRuntimeRepKindedTy
result_ty
=
return
(
Nothing
,
id
)
-- fixme this seems like a hack
-- Base case 1a: unboxed tuples
|
Just
(
tc
,
args
)
<-
splitTyConApp_maybe
result_ty
,
isUnboxedTupleTyCon
tc
{- && False -}
=
do
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment