Bodigrim authored 1 year ago and Marge Bot committed 1 year ago

Approved by CLC in https://github.com/haskell/core-libraries-committee/issues/68#issuecomment-1221409837

Matthew Craven authored 2 years ago and Marge Bot committed 1 year ago

Closes #20532. This implements CLC proposal 104:
  https://github.com/haskell/core-libraries-committee/issues/104



The design is explained in Note [DataToTag overview]
in GHC.Tc.Instance.Class. This replaces the existing
`dataToTag#` primop.

These metric changes are not "real"; they represent Unique-related
flukes triggering on a different set of jobs than they did previously.
See also #19414.

Metric Decrease:
    T13386
    T8095
Metric Increase:
    T13386
    T8095

Co-authored-by: Simon Peyton Jones <simon.peytonjones@gmail.com>

Krzysztof Gogolewski authored 1 year ago and Marge Bot committed 1 year ago

"where" should be after the injectivity annotation.

Hécate Moonlight authored 1 year ago and Marge Bot committed 1 year ago

Proposal link: https://github.com/haskell/core-libraries-committee/issues/182

Bodigrim authored 1 year ago and Marge Bot committed 1 year ago

See https://github.com/haskell/core-libraries-committee/issues/167 for discussion

Metric Decrease:
    T8095
    T13386
Metric Increase:
    T13386
    T8095

T8095 ghc/alloc decreased on x86_64, but increased on aarch64.
T13386 ghc/alloc decreased on x86_64-windows, but increased on other platforms.
Neither has anything to do with `foldl'`, so I conclude that both are flaky.

Ben Gamari authored 1 year ago and Marge Bot committed 1 year ago

This addresses an odd asymmetry in the ByteArray# primops, which
previously provided unsafeFreezeByteArray# but no corresponding
thaw operation.

Closes #22710

Ben Gamari authored 2 years ago and Marge Bot committed 1 year ago

This adds testing infrastructure to ensure that changes in core
libraries (e.g. `base` and `ghc-prim`) are caught in CI.