Matthew Pickering authored 1 year ago and Marge Bot committed 1 year ago

Tickets like #22884 suggest that it is confusing that GHC used on the
command line can suggest options which only work in GHCi.

This ticket uses the error message infrastructure to override certain
error messages which displayed GHCi specific information so that this
information is only showed when using GHCi.

The main annoyance is that we mostly want to display errors in the same
way as before, but with some additional information. This means that the
error rendering code has to be exported from the Iface/Errors/Ppr.hs
module.

I am unsure about whether the approach taken here is the best or most
maintainable solution.

Fixes #22884

Rodrigo Mesquita authored 2 years ago and Marge Bot committed 1 year ago

This commit adds support for computing an inputs hash for packages
compiled by hadrian. The result is that ABI incompatible packages should
be given different hashes and therefore be distinct in a cabal store.

Hashing is enabled by the `--flag`, and is off by default as the hash
contains a hash of the source files. We enable it when we produce
release builds so that the artifacts we distribute have the right unit
ids.

Matthew Pickering authored 2 years ago and Marge Bot committed 1 year ago

This patch converts all the errors to do with loading interface files
into proper structured diagnostics.

* DriverMessage: Sometimes in the driver we attempt to load an interface
  file so we embed the IfaceMessage into the DriverMessage.
* TcRnMessage: Most the time we are loading interface files during
  typechecking, so we embed the IfaceMessage

This patch also removes the TcRnInterfaceLookupError constructor which
is superceded by the IfaceMessage, which is now structured compared to
just storing an SDoc before.

Ben Gamari authored 2 years ago and Marge Bot committed 2 years ago

Updates `text` and `exceptions` submodules for bounds bumps.

Addresses #22767.

M Farkas-Dyck authored 2 years ago and Marge Bot committed 2 years ago

To do so, we mark some tests broken in this configuration.

Necessary for newer cross-compiling backends (JS, Wasm) that don't
support TH yet.

Ben Gamari authored 2 years ago and Marge Bot committed 2 years ago

Previously several tests' output were unnecessarily dependent on version
numbers, particularly of `base`. Fix this.

Ben Gamari authored 2 years ago and Marge Bot committed 2 years ago

To 0.9.0 and 4.17.0 respectively.

Bumps array, deepseq, directory, filepath, haskeline, hpc, parsec, stm,
terminfo, text, unix, haddock, and hsc2hs submodules.

(cherry picked from commit ba47b951)

Ben Gamari authored 2 years ago and Marge Bot committed 2 years ago

Test that we can successfully link against C++ code both in GHCi and
batch compilation.

See #20010

Ben Gamari authored 3 years ago and Marge Bot committed 3 years ago

Addresses #20653.

Joachim Breitner authored 3 years ago and Marge Bot committed 3 years ago

else the output may depend on the input order, which seems it may depend
on the concrete Uniques, which is causing headaches when including test
cases about that.

Ryan Scott authored 3 years ago and Zubin committed 3 years ago

`GHC.Hs.Syn.Type`

The existing `hsPatType`, `hsLPatType` and `hsLitType` functions have also been
moved to this module

This is a less ambitious take on the same problem that !2182 and !3866
attempt to solve. Rather than have the `hsExprType` function attempt to
efficiently compute the `Type` of every subexpression in an `HsExpr`, this
simply computes the overall `Type` of a single `HsExpr`.

- Explicitly forbids the `SplicePat` `HsIPVar`, `HsBracket`, `HsRnBracketOut`
  and `HsTcBracketOut` constructors during the typechecking phase by using
  `Void` as the TTG extension field
- Also introduces `dataConCantHappen` as a domain specific alternative to `absurd`
  to handle cases where the TTG extension points forbid a constructor.
- Turns HIE file generation into a pure function that doesn't need access to the
  `DsM` monad to compute types, but uses `hsExprType` instead.
- Computes a few more types during HIE file generation
- Makes GHCi's `:set +c` command also use `hsExprType` instead of going through
  the desugarer to compute types.

Updates haddock submodule

Co-authored-by: Zubin Duggal <zubin.duggal@gmail.com>

Sylvain Henry authored 4 years ago and Marge Bot committed 4 years ago

See discussion in #13009 (comment 268610)

Sylvain Henry authored 4 years ago and Marge Bot committed 4 years ago

* remove references to `-package-key` which has been removed in 2016
  (240ddd7c)

* remove support for `-this-package-key` which has been deprecated at the
  same time

Sylvain Henry authored 5 years ago and Marge Bot committed 4 years ago

Update Haddock submodule

Sylvain Henry authored 5 years ago and Marge Bot committed 4 years ago

Update Haddock submodule

Metric Increase:
   haddock.compiler

Sylvain Henry authored 5 years ago and Marge Bot committed 5 years ago

Add GHC.Hs module hierarchy replacing hsSyn.

Metric Increase:
    haddock.compiler

Roland Senn authored 6 years ago and Ömer Sinan Ağacan committed 6 years ago

Replace the error message
    `Use -v to see a list of the files searched for.`
with
    `Use -v (or :set -v` in ghci) to see a list of the files searched for.`

Reviewers: bgamari, monoidal, thomie, osa1

Subscribers: rwbarton, carter

GHC Trac Issues: #13862

Differential Revision: https://phabricator.haskell.org/D5122

Bumps containers submodule, among others.

This reverts commit 50e7bff7.

Reverts submodule changes.

Sigh, the haskeline commit isn't quite upstream yet.

Bumps containers submodule, among others.

If a module cannot be found because it is ignored or from an unusable
package, report this to the user and the reason it is unusable.

Currently, GHC displays the standard "Cannot find module error". For
example:

```
<no location info>: error:
    Could not find module ‘Control.Monad.Random’
    Perhaps you meant
      Control.Monad.Reader (from mtl-2.2.2)
      Control.Monad.Cont (from mtl-2.2.2)
      Control.Monad.Error (from mtl-2.2.2)
```

GHC does, however, indicate unusable/ignored packages with the -v flag:

```
package MonadRandom-0.5.1-1421RgpXdhC8e8UI7D3emA is unusable due to
missing dependencies:
  fail-4.9.0.0-BAHmj60kS5K7NVhhKpm9J5
```

With this change, I took that message and added it to the output of the
"Cannot find module" message.

Reviewers: bgamari, dfeuer

Reviewed By: bgamari

Subscribers: Phyx, dfeuer, rwbarton, thomie, carter

GHC Trac Issues: #4806

Differential Revision: https://phabricator.haskell.org/D4783

Chaitanya Koparkar authored 6 years ago and Ben Gamari committed 6 years ago

Test Plan: validate

Reviewers: bgamari, RyanGlScott, osa1

Reviewed By: bgamari

Subscribers: rwbarton, thomie, carter

GHC Trac Issues: #15055

Differential Revision: https://phabricator.haskell.org/D4669

Chaitanya Koparkar authored 6 years ago and Ben Gamari committed 6 years ago

Test Plan: make test TEST=T15055

Reviewers: bgamari, RyanGlScott, osa1, Iceland_jack

Reviewed By: osa1

Subscribers: ulysses4ever, thomie, carter

GHC Trac Issues: #15055

Differential Revision: https://phabricator.haskell.org/D4621

Edward Z. Yang authored 7 years ago and Ben Gamari committed 7 years ago

See comment in Packages for more details.

Fixes #14717.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Test Plan: validate

Reviewers: snoyberg, taylorfausak, bgamari

Reviewed By: snoyberg, taylorfausak, bgamari

Subscribers: rwbarton, thomie, carter

GHC Trac Issues: #14717

Differential Revision: https://phabricator.haskell.org/D4376

Reviewers: bgamari

Subscribers: rwbarton, thomie, carter

Differential Revision: https://phabricator.haskell.org/D4340

Bumps containers, time, and unix submodules.

This reverts commit c347a121.

They broke everything and the solution will be non-trivial.

This reverts commit 8ccbc2e5.
This reverts commit c8d995db.
This reverts commit 71533702.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Summary:
This patch implements Backpack for GHC.  It's a big patch but I've tried quite
hard to keep things, by-in-large, self-contained.

The user facing specification for Backpack can be found at:

    https://github.com/ezyang/ghc-proposals/blob/backpack/proposals/0000-backpack.rst

A guide to the implementation can be found at:

    https://github.com/ezyang/ghc-proposals/blob/backpack-impl/proposals/0000-backpack-impl.rst



Has a submodule update for Cabal, as well as a submodule update
for filepath to handle more strict checking of cabal-version.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Test Plan: validate

Reviewers: simonpj, austin, simonmar, bgamari, goldfire

Subscribers: thomie, mpickering

Differential Revision: https://phabricator.haskell.org/D1482

This is the new designated release to go with GHC 8.0.1

This is only a meta-data change relative to v0.5.7.0

/cc @foxik

This is the designated release to go with GHC 8.0.1

This release doesn't need any warning-suppression flags anymore, so
remove those from mk/warnings.mk

/cc @foxik

Differential Revision: https://phabricator.haskell.org/D1545

This reverts commit 214596de.

This reverts commit bac927b9.

As it turns out, we need these commits for separate compilation
and accurate dependency tracking.  So back in they go!

No point in pretending other compilers can use the GHC testsuite. This
makes the *.T files a bit shorter.

This reverts commit a7524eae.

Summary:
A common pattern when programming with signatures is to combine multiple
signatures together (signature linking).  We achieve this by making it
not-an-error to have multiple, distinct interface files for the same module
name, as long as they have the same backing implementation.  When a user
imports a module name, they get ALL matching signatures dumped into their
scope.

On the way, I refactored the module finder code, which now distinguishes
between exact finds (when you had a 'Module') and regular finds (when
you had a 'ModuleName').  I also refactored the package finder code to
use a Monoid instance on LookupResult to collect together various results.

ToDo: At the moment, if a signature is declared in the local package,
it completely overrides any remote signatures.  Eventually, we'll want
to also pull in the remote signatures (or even override the local signature,
if the full implementation is available.)  There are bunch of ToDos in the
code for what to do once this is done.

ToDo: At the moment, whenever a module name lookup occurs in GHCi and we
would have seen a signature, we instead continue and return the Module
for the backing implementation.  This is correct for most cases, but there
might be some situations where we want something a little more fine-grained
(e.g. :browse should only list identifiers which are available through
the in-scope signatures, and not ALL of them.)

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Test Plan: validate

Reviewers: simonpj, hvr, austin

Subscribers: carter, thomie

Differential Revision: https://phabricator.haskell.org/D790

GHC Trac Issues: #9252