- Dec 23, 2014
-
-
rwbarton authored
Summary: Note: This commit includes an API change to GhciMonad.runDecls to allow the caller to determine whether the declarations were run successfully or not. Test Plan: harbormaster Reviewers: austin Reviewed By: austin Subscribers: carter, thomie Differential Revision: https://phabricator.haskell.org/D582
-
rwbarton authored
Summary: Some Trues and Falses were mixed up due to Bool being used in different senses in different parts of GHCi. Test Plan: harbormaster; validate Reviewers: austin Reviewed By: austin Subscribers: carter, thomie Differential Revision: https://phabricator.haskell.org/D581 GHC Trac Issues: #9905 Conflicts: ghc/InteractiveUI.hs
-
Herbert Valerio Riedel authored
This is not a proper fix as the `x` in `make[x]: ...` changes depending on how the testsuite was called. So this probably only works when invoked via ./validate.
-
Simon Peyton Jones authored
This patch makes the renamer check for self-import, especially when dependencies change, because the typechecker can fall over if that happens. I'm still uneasy about *indirect* self-import, but I'll leave that for another day
-
Simon Peyton Jones authored
I found several tests that failed when the interface file format changed, due to leftover .hi file droppings. I'm not sure I've done this right, but it should be a bit better
-
Simon Peyton Jones authored
This replaces a bunch of boolean flags in ReportErrCtxt with an algebraic data type to say how to handle expression holes and type holes No change in functionality; I just found myself unable to understand the code easily, when thinking about something else. Result is quite nice, I think.
-
Simon Peyton Jones authored
-
Simon Peyton Jones authored
-
Simon Peyton Jones authored
The purpose of silent superclass parameters was to solve the awkward problem of superclass dictinaries being bound to bottom. See THE PROBLEM in Note [Recursive superclasses] in TcInstDcls Although the silent-superclass idea worked, * It had non-local consequences, and had effects even in Haddock, where we had to discard silent parameters before displaying instance declarations * It had unexpected peformance costs, shown up by Trac #3064 and its test case. In monad-transformer code, when constructing a Monad dictionary you had to pass an Applicative dictionary; and to construct that you neede a Functor dictionary. Yet these extra dictionaries were often never used. (All this got much worse when we added Applicative as a superclass of Monad.) Test T3064 compiled *far* faster after silent superclasses were eliminated. * It introduced new bugs. For example SilentParametersOverlapping, T5051, and T7862, all failed to compile because of instance overlap directly because of the silent-superclass trick. So this patch takes a new approach, which I worked out with Dimitrios in the closing hours before Christmas. It is described in detail in THE PROBLEM in Note [Recursive superclasses] in TcInstDcls. Seems to work great! Quite a bit of knock-on effect * The main implementation work is in tcSuperClasses in TcInstDcls Everything else is fall-out * IdInfo.DFunId no longer needs its n-silent argument * Ditto IDFunId in IfaceSyn * Hence interface file format changes * Now that DFunIds do not have silent superclass parameters, printing out instance declarations is simpler. There is tiny knock-on effect in Haddock, so that submodule is updated * I realised that when computing the "size of a dictionary type" in TcValidity.sizePred, we should be rather conservative about type functions, which can arbitrarily increase the size of a type. Hence the new datatype TypeSize, which has a TSBig constructor for "arbitrarily big". * instDFunType moves from TcSMonad to Inst * Interestingly, CmmNode and CmmExpr both now need a non-silent (Ord r) in a couple of instance declarations. These were previously silent but must now be explicit. * Quite a bit of wibbling in error messages
-
Simon Peyton Jones authored
-
joehillen authored
Summary: Signed-off-by: Joe Hillenbrand <joehillen@gmail.com> Reviewers: thomie, austin Reviewed By: thomie, austin Subscribers: carter, thomie Differential Revision: https://phabricator.haskell.org/D566 GHC Trac Issues: #9876
-
Sergei Trofimovich authored
Summary: The bug manifests when built with EXTRA_HC_OPTS += -g +++ ./ghci.debugger/scripts/break028.run.stderr 2014-12-19 23:08:46.199876621 +0000 @@ -0,0 +1,11 @@ +ghc-stage2: panic! (the 'impossible' happened) + (GHC version 7.9.20141219 for x86_64-unknown-linux): + getIdFromTrivialExpr x_alJ + +Please report this as a GHC bug: http://www.haskell.org/ghc/reportabug + + +<interactive>:3:1: Not in scope: ‘g’ + +<interactive>:3:3: Not in scope: data constructor ‘False’ Signed-off-by:
Sergei Trofimovich <siarheit@google.com> Reviewers: simonmar, austin, scpmw Reviewed By: scpmw Subscribers: carter, thomie Differential Revision: https://phabricator.haskell.org/D580
-
thomasw authored
Summary: Mind the capital C. As there is already a flag RecordWildCards with a capital C, we should at least try to be consistent in the spelling of WildCards. Test Plan: validate Reviewers: goldfire, simonpj, austin Reviewed By: simonpj, austin Subscribers: carter, thomie Differential Revision: https://phabricator.haskell.org/D584
-
thomasw authored
Summary: Running `:kind _` in GHCi produced a panic, fix it by extracting the wildcards. Now, `:kind _` produces `_ :: k0`. Unfortunately, a `0` is added after the kind is tidied and I haven't found a way to get rid of it... This does not fix the other panic involving TemplateHaskell mentioned in #9879. Test Plan: new test GHCiWildcardKind should pass Reviewers: austin, simonpj Reviewed By: austin Subscribers: simonpj, carter, thomie, monoidal Differential Revision: https://phabricator.haskell.org/D572 GHC Trac Issues: #9879
-
Austin Seipp authored
Signed-off-by:
Austin Seipp <austin@well-typed.com>
-
- Dec 22, 2014
-
-
Facundo Domínguez authored
Reviewed By: austin Differential Revision: https://phabricator.haskell.org/D574
-
Facundo Domínguez authored
Reviewed By: austin Differential Revision: https://phabricator.haskell.org/D575
-
Richard Eisenberg authored
-
Herbert Valerio Riedel authored
This needs to update the Haddock submodule as well Signed-off-by:
Herbert Valerio Riedel <hvr@gnu.org>
-
Herbert Valerio Riedel authored
This typo slipped in through 3549c952
-
Austin Seipp authored
This reverts commit 18bf6d5d. We forgot to tweak some of the submodule bounds. Fixes incoming soon.
-
Austin Seipp authored
Signed-off-by:
Austin Seipp <austin@well-typed.com>
-
Simon Peyton Jones authored
-
Simon Peyton Jones authored
This fixes Trac #9881, and gives more helpful output in the case of ambiguity. Certainly more helpful than the positively-misleading error we get right now.
-
Herbert Valerio Riedel authored
-
Herbert Valerio Riedel authored
This updates those two packages to their most recent respective proper releases.
-
Gergő Érdi authored
-
- Dec 21, 2014
-
-
Gergő Érdi authored
-
Gergő Érdi authored
look like prefixes of valid declarations (fixes #9915)
-
- Dec 20, 2014
-
-
Luite Stegeman authored
Summary: This allows GHC API clients to use a package database and dynamic library names that do not clash with those of the host GHC This also updates the Haddock submodule. Reviewers: hvr, austin Reviewed By: austin Subscribers: thomie, carter Differential Revision: https://phabricator.haskell.org/D496
-
Luite Stegeman authored
Summary: The runMeta hook can be used to override how metaprogramming expressions are evaluated. It makes the metaprogramming request types explicit and has access to the TcM monad. This makes it a much more convenient starting point for implementing out of process Template Haskell than the existing hscCompileCoreExpr hook. Reviewers: hvr, edsko, austin, simonpj Reviewed By: austin Subscribers: thomie, carter Differential Revision: https://phabricator.haskell.org/D501
-
Gergő Érdi authored
-
Richard Eisenberg authored
-
Richard Eisenberg authored
This has a demonstrated 2x speed boost on the T9872{a,b,c} tests. (#9872)
-
Edward Z. Yang authored
Signed-off-by:
Edward Z. Yang <ezyang@cs.stanford.edu>
-
- Dec 19, 2014
-
-
Herbert Valerio Riedel authored
[skip ci]
-
Herbert Valerio Riedel authored
-
Herbert Valerio Riedel authored
This pulls in > make `getModificationTime` support sub-second resolution on windows
-
Herbert Valerio Riedel authored
-
Richard Eisenberg authored
-