Cheng Shao authored 2 years ago and Marge Bot committed 2 years ago

Cleanup legacy boot script args, following removal of the legacy make
build system.

Ben Gamari authored 2 years ago and Marge Bot committed 2 years ago

Here we at long last remove the `make`-based build system, it having
been replaced with the Shake-based Hadrian build system. Users are
encouraged to refer to the documentation in `hadrian/doc` and this [1]
blog post for details on using Hadrian.

Closes #17527.

[1] https://www.haskell.org/ghc/blog/20220805-make-to-hadrian.html

Ben Gamari authored 2 years ago and Marge Bot committed 2 years ago

In preparation for removal of the legacy `make`-based build system.

Ben Gamari authored 2 years ago and Marge Bot committed 2 years ago

Currently the `$make` variable is used without being set in `validate`'s
Hadrian path, which uses make to install the binary distribution. Fix
this.

Fixes #21687.

Matthew Pickering authored 2 years ago and Marge Bot committed 2 years ago

In the validate script we are careful to use the $make variable as this
stores whether we are using gmake, make, quiet mode etc. There was just
this one place where we failed to use it.

Fixes #21598

Greg Steuck authored 3 years ago and Marge Bot committed 3 years ago

Asked the question:
!7460 (diffs)

Greg Steuck authored 3 years ago and Marge Bot committed 3 years ago

The whitespace expansion should be permitted to pass multiple
arguments to configure.

Ben Gamari authored 3 years ago and Marge Bot committed 3 years ago

Previously we would only look for a `python` executable, but in general
we should prefer `python3` and sometimes `python` doesn't exist.

Alina Banerjee authored 4 years ago and Marge Bot committed 3 years ago

ShellCheck(https://github.com/koalaman/shellcheck/wiki) has been used to check
the script.

Ben Gamari authored 4 years ago and Marge Bot committed 4 years ago

Previously the Hadrian codepath of `validate` inverted the logic which
decides whether the test build of `xhtml` should be built with
`--enable-shared`. This resulted in validate failures on Windows, which
does not support dynamic linkage of Haskell code.

Andreas Klebinger authored 4 years ago and Marge Bot committed 4 years ago

Fixes #19307

Cheng Shao authored 4 years ago and Marge Bot committed 4 years ago

The validate flavour is already defined and used in hadrian, so this
legacy comment should be removed.

Greg Steuck authored 4 years ago and Marge Bot committed 4 years ago

Fix #18944

xldenis authored 5 years ago and Marge Bot committed 5 years ago

Convert hadrian buildscripts to unsuffixed, dashed form

final cleanups

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

This script was previously a whitespace nightmare.

Alp Mestanogullari authored 5 years ago and Marge Bot committed 5 years ago

When the '--hadrian' flag is passed to the validate script, we use hadrian
to build GHC, package it up in a binary distribution and later on run GHC's
testsuite against the said bindist, which gets installed locally in the process.

Along the way, this commit fixes a typo, an omission (build iserv binaries
before producing the bindist archive) and moves the Makefile that enables
'make install' on those bindists from being a list of strings in the code to
an actual file (it was becoming increasingly annoying to work with).

Finally, the Settings.Builders.Ghc part of this patch is necessary for being
able to use the installed binary distribution, in 'validate'.

Takenobu Tani authored 6 years ago and Marge Bot committed 6 years ago

This moves all URL references to Trac Wiki to their corresponding
GitLab counterparts.

This substitution is classified as follows:

1. Automated substitution using sed with Ben's mapping rule [1]
    Old: ghc.haskell.org/trac/ghc/wiki/XxxYyy...
    New: gitlab.haskell.org/ghc/ghc/wikis/xxx-yyy...

2. Manual substitution for URLs containing `#` index
    Old: ghc.haskell.org/trac/ghc/wiki/XxxYyy...#Zzz
    New: gitlab.haskell.org/ghc/ghc/wikis/xxx-yyy...#zzz

3. Manual substitution for strings starting with `Commentary`
    Old: Commentary/XxxYyy...
    New: commentary/xxx-yyy...

See also !539

[1]: https://gitlab.haskell.org/bgamari/gitlab-migration/blob/master/wiki-mapping.json

- Remove dph from validate; dph was removed
- The required-tag argument to boot was used only for dph, remove
- check_boot_packages() was not called at all, and didn't work.
  I fixed it based on previous Perl version.

Test Plan: Harbormaster

Reviewers: bgamari, thomie

Reviewed By: bgamari

Subscribers: rwbarton, carter

Differential Revision: https://phabricator.haskell.org/D5129

Ben Gamari authored 6 years ago and Ben Gamari committed 6 years ago

Test Plan: Try `./validate`, CircleCI build; make sure core count
detection works in both cases.

Reviewers: alpmestan

Reviewed By: alpmestan

Subscribers: rwbarton, thomie, carter

GHC Trac Issues: #14470

Differential Revision: https://phabricator.haskell.org/D4897

Ben Gamari authored 6 years ago and Ben Gamari committed 6 years ago

Poor DPH and its vectoriser have long been languishing; sadly it seems there is
little chance that the effort will be rekindled. Every few years we discuss
what to do with this mass of code and at least once we have agreed that it
should be archived on a branch and removed from `master`. Here we do just that,
eliminating heaps of dead code in the process.

Here we drop the ParallelArrays extension, the vectoriser, and the `vector` and
`primitive` submodules.

Test Plan: Validate

Reviewers: simonpj, simonmar, hvr, goldfire, alanz

Reviewed By: simonmar

Subscribers: goldfire, rwbarton, thomie, mpickering, carter

Differential Revision: https://phabricator.haskell.org/D4761

Ben Gamari authored 7 years ago and Ben Gamari committed 7 years ago

One step closer to being able to drop the Windows Perl tarball. We
previously attempted to do this in D3567 but were forced to revert due
to Windows problems.

Acknowledgements:
 * @Phyx kindly contributed the codepath allowing this to work on
Windows.

Test Plan: Validate

Reviewers: hvr, austin, Phyx

Subscribers: erikd, thomie, rwbarton

Differential Revision: https://phabricator.haskell.org/D3918

Ben Gamari authored 7 years ago and Ben Gamari committed 7 years ago

Test Plan: Validate, try ingesting into Jenkins.

Reviewers: austin

Subscribers: rwbarton, thomie

GHC Trac Issues: #13716

Differential Revision: https://phabricator.haskell.org/D3796

This reverts commit 0440af6a.
Unfortunately this breaks on Windows for tiresome reasons. I'll need to
reevaluate this.

Ben Gamari authored 7 years ago and Ben Gamari committed 7 years ago

Test Plan: Validate

Reviewers: hvr, austin

Subscribers: rwbarton, thomie, erikd

Differential Revision: https://phabricator.haskell.org/D3567

Ben Gamari authored 7 years ago and Ben Gamari committed 7 years ago

For reasons unknown `validate` passed `NO_CLEAN_GMP=YES` to
`maintainer-clean`, leaving a stale `gmp.h` which causes the build to
fail in the event that the uses a tree for validating for two different
target platforms. This is quite unexpected, don't do it.

Reviewers: hvr, austin, rwbarton, dfeuer

Reviewed By: dfeuer

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D3409

Ben Gamari authored 8 years ago and Ben Gamari committed 8 years ago

Due to #12554 and #12661 we must be quite picky about our choice of
Python interpreter on Windows. Allow the user to override it.

Test Plan: `PYTHON=/usr/bin/python2 ./validate` on Windows

Reviewers: austin, Phyx

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D2603

GHC Trac Issues: #12554, #12661

Ben Gamari authored 8 years ago and Ben Gamari committed 8 years ago

This will allow us to split up Harbormaster output for the build and
test stages of validation.

Test Plan: `./validate --build-only && ./validate --testsuite-only`

Reviewers: thomie, hvr, austin

Differential Revision: https://phabricator.haskell.org/D2553