And refer to it from the various places involved in the scheme.

Add a sub-subsection in the chapter on GHC extensions to the FFI, under
the existing Memory Allocation subsection.

Explain that it's permitted to have {Mutable}ByteArray# outside the heap
and the tricky associated constraints. Mention the new primop
placeByteArray#.

Closes issue #17747

Test that we can allocate ByteArray#s outside of the HEAP_ALLOCED()
address space without upsetting the GC. To be extra sure we attach weak
pointers with C finalizers to the ByteArray#s. We keep them alive and
run a major GC so that the GC has to trace the live ByteArray#s.

Prior to the first patch in this series, doing this would upset the GC
because the GC does not expect heap objects with closure type ARR_WORDS
to exist outside the GC heap.

> internal error: evacuate(static): strange closure type 42

Finally we allow everything to be GC'd again, and check that the C
finalizers did run.

This feature also required a change to the isByteArrayPinned# which
itself required a CMM implementation of the HEAP_ALLOCED system. So we
also add a check that the CMM and C implementations of HEAP_ALLOCED
agree with each other.

The isByteArrayPinned# primop works by looking up the block descriptor
for the byte array to see if it lives in a pinned area or not. This of
course cannot work for byte arrays that are not HEAP_ALLOCATED since
they don't have block descriptors.

The solution is to check if it is HEAP_ALLOCATED first. Since this is
done in CMM code we make use of the new HEAP_ALLOCATED support for CMM.
It is a bit awkward since it does not have a uniform interface.

Allow rts/sm/HeapAlloc.h to be #included by CMM code and have it provide
a suitable implementation of HEAP_ALLOCED.

The HEAP_ALLOCED system has three implementations, the large address
space case, two fallbakc impls, one for 32bit and one for 64bit. The
first two are simple enough that we can provide a HEAP_ALLOCED macro
that can be used in a CMM expression context.

The 64bit fallback case is rather more tricky. We provide a different
interface to HEAP_ALLOCED for this case, which has to be called in a
statement/"callish" style.

It places a byte array heap object header at the given address, which
must be outside the heap. It also sets the byte array size.

In the GC, evacuate() is prepared to deal with some heap objects that
are not in the HEAP_ALLOCED() memory space. These are mainly the heap
objects that GHC puts into the data sections of object files.

It is also useful however to allow ByteArray# and MutableByteArray#
heap objects to appear outside of the HEAP_ALLOCED() memory space. These
have the ARR_WORDS closure type and contain no pointer should be easy to
deal with. Indeed evacuate() already deals with closure types for
constructors containing no pointers by doing nothing.

So we just tack the ARR_WORDS case into this group of closure types that
are permitted outside the HEAP_ALLOCED area but otherwise ignored.

Cheng Shao authored 9 months ago and Marge Bot committed 9 months ago

This patch replaces the ad-hoc `MYTASK_USE_TLV` with the
`CC_SUPPORTS_TLS` macro. If TLS support is detected by autoconf, then
we should use that for managing `myTask` in the threaded RTS.

jeffrey young authored 9 months ago and Marge Bot committed 9 months ago

In pursuit of: #22736.

This MR moves ad-hoc symbols used throughout the js backend into a
single symbols file. Why? First, this cleans up the code by removing
ad-hoc strings created on the fly and therefore makes the code more
maintainable. Second, it makes it much easier to eventually type these
identifiers.

Ben Gamari authored 9 months ago and Marge Bot committed 9 months ago

The comment wasn't clear in stating that it was only applicable to
immediate source and memory target operands.

Bodigrim authored 9 months ago and Marge Bot committed 9 months ago

A low-tech tactical solution for #24919

Cheng Shao authored 9 months ago and Marge Bot committed 9 months ago

This patch removes pre-C11 legacy code paths related to
INLINE_HEADER/STATIC_INLINE/EXTERN_INLINE macros, ensure EXTERN_INLINE
is treated as static inline in most cases (fixes #24945), and also
corrects the comments accordingly.

Cheng Shao authored 9 months ago and Marge Bot committed 9 months ago

objc-hi/objcxx-hi should be skipped when cross compiling. The existing
opsys('darwin') predicate only asserts the host system is darwin but
tells us nothing about the target, hence the oversight.

Sylvain Henry authored 9 months ago and Marge Bot committed 9 months ago

Since 6755d833 this code is dead.

Sylvain Henry authored 9 months ago and Marge Bot committed 9 months ago

- Change arguments order to avoid `\args -> ...` lambdas
- Fix documentation
- Rename StgToCmm options ("big" doesn't mean anything)

Sebastian Graf authored 9 months ago and Marge Bot committed 9 months ago

Leftover from !9229.

Ben Gamari authored 9 months ago and Marge Bot committed 9 months ago

Fixes #24899. Also place it under `extra-doc-files` to better reflect
its nature and avoid triggering unnecessary recompilation if it
changes.

Georgi Lyubenov authored 1 year ago and Marge Bot committed 9 months ago

Please see https://github.com/haskell/core-libraries-committee/issues/172
for related discussion

Cheng Shao authored 9 months ago and Marge Bot committed 9 months ago

This commit mentions removal of 32-bit darwin/ios support (#24921) in
the 9.12 changelog.

Cheng Shao authored 9 months ago and Marge Bot committed 9 months ago

This commit removes 32-bit darwin logic from the testsuite given it's
no longer supported (#24921). Also contains more cleanup of obsolete
i386 windows logic.

Cheng Shao authored 9 months ago and Marge Bot committed 9 months ago

This commit removes 32-bit darwin/ios targets from llvm-targets given
we no longer support them (#24921).

Cheng Shao authored 9 months ago and Marge Bot committed 9 months ago

This commit removes 32-bit darwin/ios related logic from the rts,
given we no longer support them (#24921).

Cheng Shao authored 9 months ago and Marge Bot committed 9 months ago

This commit removes all 32-bit darwin logic from the compiler, given
we no longer support 32-bit apple systems (#24921). Also contains a
bit more cleanup of obsolete i386 windows logic.

Cheng Shao authored 9 months ago and Marge Bot committed 9 months ago

This commit removes mentioning of OSDarwin from speedHack, since
speedHack is purely for i386 and we no longer support i386 darwin
(#24921).

Cheng Shao authored 9 months ago and Marge Bot committed 9 months ago

This commit applies path normalization via cygpath -m to some
build-time dependencies on Windows. Without this logic, the
/clang64/bin prefixed msys2-style paths cause the build to fail with
--enable-distro-toolchain.

Cheng Shao authored 9 months ago and Marge Bot committed 9 months ago

This commit removes unused PowerPC/IA64 native adjustor code which is
never actually enabled by autoconf/hadrian. Fixes #24920.

Cheng Shao authored 9 months ago and Marge Bot committed 9 months ago

This patch removes CompilerInfo/LinkerInfo types from the compiler
since they aren't actually used anywhere.

Teo Camarasu authored 9 months ago and Marge Bot committed 9 months ago

This function should never be inlined in order to keep code size small.