Fix #13948 by being pickier about when to suggest DataKinds
Commit 343cb32d (#13568) made GHC a bit too cavalier in suggesting when data constructors are in scope (and suggesting the use of `DataKinds`). This tones down the suggestions so that `DataKinds` is only suggested if a data constructor of that name is actually in scope (previously, it would always suggest, even if it was out of scope). Fixes #13948. Test Plan: ./validate Reviewers: mpickering, austin, bgamari Reviewed By: mpickering Subscribers: rwbarton, thomie GHC Trac Issues: #13948 Differential Revision: https://phabricator.haskell.org/D3719
Showing
- compiler/rename/RnEnv.hs 10 additions, 1 deletioncompiler/rename/RnEnv.hs
- testsuite/tests/module/mod122.stderr 1 addition, 3 deletionstestsuite/tests/module/mod122.stderr
- testsuite/tests/module/mod123.stderr 1 addition, 3 deletionstestsuite/tests/module/mod123.stderr
- testsuite/tests/module/mod124.stderr 0 additions, 1 deletiontestsuite/tests/module/mod124.stderr
- testsuite/tests/module/mod127.stderr 0 additions, 1 deletiontestsuite/tests/module/mod127.stderr
- testsuite/tests/module/mod29.stderr 0 additions, 1 deletiontestsuite/tests/module/mod29.stderr
- testsuite/tests/module/mod50.stderr 1 addition, 3 deletionstestsuite/tests/module/mod50.stderr
- testsuite/tests/parser/should_fail/readFail001.stderr 0 additions, 1 deletiontestsuite/tests/parser/should_fail/readFail001.stderr
- testsuite/tests/rename/prog003/rename.prog003.stderr 1 addition, 3 deletionstestsuite/tests/rename/prog003/rename.prog003.stderr
- testsuite/tests/rename/should_fail/T1595a.stderr 0 additions, 1 deletiontestsuite/tests/rename/should_fail/T1595a.stderr
- testsuite/tests/rename/should_fail/T5745.stderr 1 addition, 3 deletionstestsuite/tests/rename/should_fail/T5745.stderr
- testsuite/tests/typecheck/should_fail/T1595.stderr 0 additions, 2 deletionstestsuite/tests/typecheck/should_fail/T1595.stderr
- testsuite/tests/typecheck/should_fail/tcfail048.stderr 0 additions, 1 deletiontestsuite/tests/typecheck/should_fail/tcfail048.stderr
- testsuite/tests/typecheck/should_fail/tcfail053.stderr 0 additions, 1 deletiontestsuite/tests/typecheck/should_fail/tcfail053.stderr
Loading
Please register or sign in to comment