Skip to content

genprimopcode: Don't assume the current locale is *.UTF-8, set the encoding explicitly

PHO requested to merge PHO/ghc:genprimopcode-non-utf8-locale into master

primops.txt contains Unicode characters:

% LC_ALL=C ./genprimopcode --data-decl < ./primops.txt
genprimopcode: <stdin>: hGetContents: invalid argument (cannot decode byte sequence starting from 226)

Hadrian must also avoid using readFile' to read primops.txt because it tries to decode the file with a locale-specific encoding.


  • if your MR may break existing programs (e.g. touches base or causes the compiler to reject programs), please describe the expected breakage and add the user-facing label. This will run ghc/head.hackage> to characterise the effect of your change on Hackage.
  • ensure that your commits are either individually buildable or squashed
  • ensure that your commit messages describe what they do (referring to tickets using #NNNN syntax when appropriate)
  • have added source comments describing your change. For larger changes you likely should add a [Note][notes] and cross-reference it from the relevant places.
  • add a [testcase to the testsuite][adding test].
  • updates the users guide if applicable
  • mentions new features in the release notes for the next release
Edited by PHO

Merge request reports