hadrian: track header dependencies of DeriveConstants.h
Thank you for your contribution to GHC!
Please read the checklist below to make sure your contribution fulfills these expectations. Also please answer the following question in your MR description:
Where is the key part of this patch? That is, what should reviewers look at first?
This adds a new generated file DerivedConstants.h.deps
created
via gcc -MM
(Makefile format target: dependencies
specification)
and dynamically adds those header files to DerivedConstants.h
dependencies list via need ...
.
Note that gcc -MM
step doesn't specify dependencies of its own
because it's not known in advance. It does seem to depend on
utils/deriveConstants/Main.hs
though, maybe due to it being the build tool.
Steps to verify:
$ hadrian/build _build/stage1/rts/build/include/DerivedConstants.h
$ cat ./_build/stage1/rts/build/include/DerivedConstants.h | grep "#define REP_bdescr_blocks"
#define REP_bdescr_blocks b32
### manually edit rts/include/rts/storage/Block.h: "StgWord32 blocks" -> "StdWord16 blocks"
$ hadrian/build _build/stage1/rts/build/include/DerivedConstants.h
$ cat ./_build/stage1/rts/build/include/DerivedConstants.h | grep "#define REP_bdescr_blocks"
#define REP_bdescr_blocks b16
Fixes #20593
Please take a few moments to address the following points:
-
if your MR may break existing programs (e.g. touches base
or causes the compiler to reject programs), please describe the expected breakage and add the user-facing label. This will run ghc/head.hackage> to characterise the effect of your change on Hackage. -
ensure that your commits are either individually buildable or squashed -
ensure that your commit messages describe what they do (referring to tickets using #NNNN
syntax when appropriate) -
have added source comments describing your change. For larger changes you likely should add a Note and cross-reference it from the relevant places. -
add a testcase to the testsuite. -
updates the users guide if applicable -
mentions new features in the release notes for the next release
If you have any questions don't hesitate to open your merge request and inquire
in a comment. If your patch isn't quite done yet please do add prefix your MR
title with WIP:
.
By default a minimal validation pipeline is run on each merge request, the full-ci label can be applied to perform additional validation checks if your MR affects a more unusual configuration.
Once your change is ready please remove the WIP:
tag and wait for review. If
no one has offered a review in a few days then please leave a comment mentioning
@triagers and apply the Blocked on Review label.