Skip to content
Snippets Groups Projects

nativeGen/dwarf: Fix procedure end addresses

Closed nativeGen/dwarf: Fix procedure end addresses
wip/T17605 into master
Closed Ben Gamari requested to merge wip/T17605 into master

Previously the .debug_aranges and .debug_info (DIE) DWARF information would claim that procedures (represented with a DW_TAG_subprogram DIE) would only span the range covered by their entry block. This omitted all of the continuation blocks (represented by DW_TAG_lexical_block DIEs), confusing perf. Fix this by introducing a end-of-procedure label and using this as the DW_AT_high_pc of procedure DW_TAG_subprogram DIEs

Fixes #17605 (closed).

Additionally fix two smaller issues:

  • Generate DW_TAG_source_note nodes only with -g3
  • Use the DW_AT_linkage_name attribute instead of DW_AT_MIPS_linkage_name (it's unclear why this was used originally)
Edited by Ben Gamari

Merge request reports

Merge request pipeline #27450 passed with warnings

Stage: tool-lint
Stage: quick-build
Stage: lint
Stage: build
Stage: full-build
Stage: packaging
Stage: testing

Merge request pipeline passed with warnings for 8937c9b6

Closed by Marge BotMarge Bot 4 years ago (Nov 15, 2020 8:35am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply