Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • GHC GHC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 5,261
    • Issues 5,261
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 566
    • Merge requests 566
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Glasgow Haskell CompilerGlasgow Haskell Compiler
  • GHCGHC
  • Merge requests
  • !2373

nativeGen/dwarf: Fix procedure end addresses

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Ben Gamari requested to merge wip/T17605 into master Dec 27, 2019
  • Overview 7
  • Commits 4
  • Pipelines 16
  • Changes 9

Previously the .debug_aranges and .debug_info (DIE) DWARF information would claim that procedures (represented with a DW_TAG_subprogram DIE) would only span the range covered by their entry block. This omitted all of the continuation blocks (represented by DW_TAG_lexical_block DIEs), confusing perf. Fix this by introducing a end-of-procedure label and using this as the DW_AT_high_pc of procedure DW_TAG_subprogram DIEs

Fixes #17605 (closed).

Additionally fix two smaller issues:

  • Generate DW_TAG_source_note nodes only with -g3
  • Use the DW_AT_linkage_name attribute instead of DW_AT_MIPS_linkage_name (it's unclear why this was used originally)
Edited Dec 27, 2019 by Ben Gamari
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/T17605