Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • GHC GHC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 5,240
    • Issues 5,240
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 564
    • Merge requests 564
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Glasgow Haskell CompilerGlasgow Haskell Compiler
  • GHCGHC
  • Merge requests
  • !4492

Cleanup array and conversion primops

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed John Ericson requested to merge wip/primop-naming-consistency into master Nov 23, 2020
  • Overview 24
  • Commits 1
  • Pipelines 40
  • Changes 75

(Also progress towards #11953 (closed), #17377 (closed), #17375 (closed))

Fixes #19099 (closed) though in fairness also caused #19099 (closed).

See commit message for details

Out-of-band dependency PRs:

  • https://github.com/simonmar/alex/pull/166, released in Alex 3.2.6
  • ci-images!59 (merged)

Submodule PRs:

  • https://github.com/haskell/cabal/pull/7205
  • ghc/packages/array!8 (merged)
  • https://github.com/kolmodin/binary/pull/178
  • https://github.com/haskell/bytestring/pull/354 (or https://github.com/haskell/bytestring/pull/332 for 0.10)
  • https://github.com/haskell/containers/pull/760
  • https://github.com/haskell/text/pull/305

Afterwords PRs:

  • https://github.com/alpmestan/ghc.nix/pull/97

Please take a few moments to verify that your commits fulfill the following:

  • are either individually buildable or squashed
  • have commit messages which describe what they do (referring to Notes and tickets using #NNNN syntax when appropriate)
  • have added source comments describing your change. For larger changes you likely should add a Note and cross-reference it from the relevant places.
  • add a testcase to the testsuite.
  • replace this message with a description motivating your change

If you have any questions don't hesitate to open your merge request and inquire in a comment. If your patch isn't quite done yet please do add prefix your MR title with WIP:.

Edited Mar 02, 2021 by Ben Gamari
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/primop-naming-consistency