Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
GHC
GHC
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 4,269
    • Issues 4,269
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 413
    • Merge Requests 413
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Glasgow Haskell Compiler
  • GHCGHC
  • Merge Requests
  • !4492

Open
Opened Nov 23, 2020 by John Ericson@Ericson2314Developer5 of 14 tasks completed5/14 tasks
  • Report abuse
Report abuse

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "wip/primop-naming-consistency" "origin/wip/primop-naming-consistency"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "master"
git merge --no-ff "wip/primop-naming-consistency"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Cleanup array and conversion primops (#19026)

  • Overview 18
  • Commits 2
  • Pipelines 33
  • Changes 71

(Also progress towards #11953, #17377, #17375)

Fixes #19099 though in fairness also caused #19099.

See commit message for details

Out-of-band dependency PRs:

  • https://github.com/simonmar/alex/pull/166, released in Alex 3.2.6
  • ci-images!59 (merged)

Submodule PRs:

  • https://github.com/haskell/cabal/pull/7205
  • ghc/packages/array!7
  • https://github.com/kolmodin/binary/pull/178
  • https://github.com/haskell/bytestring/pull/332
  • https://github.com/haskell/containers/pull/760
  • https://github.com/haskell/text/pull/305

Afterwords PRs:

  • https://github.com/alpmestan/ghc.nix/pull/97

Please take a few moments to verify that your commits fulfill the following:

  • are either individually buildable or squashed
  • have commit messages which describe what they do (referring to Notes and tickets using #NNNN syntax when appropriate)
  • have added source comments describing your change. For larger changes you likely should add a Note and cross-reference it from the relevant places.
  • add a testcase to the testsuite.
  • replace this message with a description motivating your change

If you have any questions don't hesitate to open your merge request and inquire in a comment. If your patch isn't quite done yet please do add prefix your MR title with WIP:.

Edited Dec 24, 2020 by John Ericson
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
Reference: ghc/ghc!4492
Source branch: wip/primop-naming-consistency