Skip to content

pin HPC submodule to most recent commit

Peter Becich requested to merge peterbecich/ghc:pin-hpc-submodule-commit into master

Update: I think this is not necessary to prevent the CI failure. Nonetheless perhaps it is good to explicitly pin the submodule commit in .gitmodules?

This PR pins the HPC submodule to the latest commit on ghc/packages/hpc:master: https://gitlab.haskell.org/ghc/packages/hpc/-/commit/7588219d1ab70166a9cd5959d6c027bcd5f75ee9

This relates to some updates to HPC:

Assuming those two PRs are approved, this PR will prevent a temporary failure in the CI pipeline for ghc/ghc:master.

Without this PR, if https://gitlab.haskell.org/ghc/packages/hpc/-/merge_requests/16 is merged before !8194 (merged), I expect CI will fail for ghc/ghc:master. However, merging https://gitlab.haskell.org/ghc/packages/hpc/-/merge_requests/16 is necessary to make CI succeed for !8194 (merged).

Pinning the commit of the HPC submodule will prevent this.

I have tested this a couple of ways, including by cloning a new copy of GHC. The correct commit is checked-out for the HPC submodule:

git clone -b pin-hpc-submodule-commit --single-branch --recurse-submodules git@gitlab.haskell.org:peterbecich/ghc.git
  • are either individually buildable or squashed
  • have commit messages which describe what they do (referring to Notes and tickets using #NNNN syntax when appropriate)
  • have added source comments describing your change. For larger changes you likely should add a Note and cross-reference it from the relevant places.
  • add a testcase to the testsuite.
  • replace this message with a description motivating your change

If you have any questions don't hesitate to open your merge request and inquire in a comment. If your patch isn't quite done yet please do add prefix your MR title with WIP:.

Edited by Peter Becich

Merge request reports