Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • GHC GHC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 5,410
    • Issues 5,410
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 604
    • Merge requests 604
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Glasgow Haskell CompilerGlasgow Haskell Compiler
  • GHCGHC
  • Merge requests
  • !9609

nonmoving: Fix a variety of bugs

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Ben Gamari requested to merge wip/T22264 into master Dec 23, 2022
  • Overview 6
  • Commits 48
  • Pipelines 25
  • Changes 42

This fixes several issues identified while looking at #22264.

  • Previously the write barrier of resizeSmallArray# would incorrectly push empty arrays to the update remembered set. This resulted in invalid pointers on the remembered set. This was the cause of #22931 (closed) .
  • Previously the nonmoving collector's treatment of weak pointer prevented some weak objects from being finalized, as described in #22327 (closed).
  • Previously setNumCapabilities could race with the nonmoving mark thread, resulting in unsound behavior (#22926 (closed))
  • Previously setNumCapabililies could drop the update remembered sets of existing capabilities, resulting in unsound behavior (#22927 (closed))
  • Previously the non-moving collector's treatment of the selector optimisation lacked a few necessary write barriers (#22930 (closed))
  • Previously the non-moving collector was liable to exhibit unusually high sync pause times in some workloads. We address this with a cheap and cheerful fuel approach to limit serial-marking effort performed by the sync pause (#22929 (closed))

The weak pointer work was especially involved since it required tightening up quite a few invariants regarding weak object handling. This was a rather significant surgery but I think the result is a great improvement over the status quo.

Edited Mar 08, 2023 by Ben Gamari
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/T22264