Add bifunctors-5.5.8
Merge request reports
Activity
Hoo boy, I was wondering when people would start noticing the fallout from the type applications in patterns patch. Turns out, sooner than I expected!
Unfortunately, I doubt that this is going to pass CI at the moment, since there hasn't been a passing CI build on GHC's
masterbranch since the aforementioned patch landed, sohead.hackagewon't be able to grab a recent enough artifact frommaster.It turns out that more work was needed to fully adapt to the fallout of the type-applications-in-patterns patch, so I went ahead and submitted a separate MR which supersedes this one. Nonetheless, thank you for opening this—I've credited you as a co-author in 5c907546.
- patches/bifunctors-5.5.8.patch 0 → 100644
1 diff --git a/src/Data/Bifunctor/TH.hs b/src/Data/Bifunctor/TH.hs 2 index 7e0b82c..f08df28 100644 3 --- a/src/Data/Bifunctor/TH.hs 4 +++ b/src/Data/Bifunctor/TH.hs 5 @@ -1236,7 +1236,7 @@ mkSimpleConMatch :: (Name -> [a] -> Q Exp) 6 -> Q Match 7 mkSimpleConMatch fold conName insides = do 8 varsNeeded <- newNameList "_arg" $ length insides 9 - let pat = ConP conName (map VarP varsNeeded) 10 + let pat = ConP conName [] (map VarP varsNeeded) For future reference, CI won't pass unless each patch compiles with HEAD, 9.0, and 8.10, so you'd need to guard the
[]here with CPP in order to keep it compiling with 8.10 and 9.0. See here.
