Skip to content
Snippets Groups Projects

Add patches for ghcide dependencies

Merged Hannes Siebenhandl requested to merge fendor/head.hackage:patch/ghcide-deps into master

Helpful to make GHCIDE compile with GHC 9.2.

Not enough to actually run it.

Patches are basically taken from:

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ryan Scott
  • added 1 commit

    • d75ba27c - Add patches for ghcide dependencies

    Compare with previous version

  • Hannes Siebenhandl resolved all threads

    resolved all threads

  • added 1 commit

    • 0197cd9a - Add patches for ghcide dependencies

    Compare with previous version

  • Ryan Scott
  • For some reason, the CI is failing to build foldl and mmorph due to cabal picking up old Hackage versions of these packages. I doubt that this is the fault of this MR, so I'll look into this separately.

  • For some reason, the CI is failing to build foldl and mmorph due to cabal picking up old Hackage versions of these packages.

    I fixed this in !177 (merged), so if you rebase on top of master, that should resolve that issue.

  • added 4 commits

    Compare with previous version

  • @RyanGlScott Rebase again or is this good to go?

  • No need to rebase, but the CI is still failing. I've left two review comments above, one of which explains how to fix the CI.

  • added 1 commit

    • d29b87fb - Add patches for ghcide dependencies

    Compare with previous version

  • added 2 commits

    • a13af4f4 - 1 commit from branch ghc:master
    • ca918a3d - Add patches for ghcide dependencies

    Compare with previous version

  • added 1 commit

    • 6ea2f246 - Add patches for ghcide dependencies

    Compare with previous version

  • Hannes Siebenhandl resolved all threads

    resolved all threads

  • Hannes Siebenhandl resolved all threads

    resolved all threads

    • Resolved by Ryan Scott

      I just wanted to leave a comment to clarify that I haven't forgotten about this. Unfortunately, there have a been a number of changes to the ghc-9.2 and master branches of GHC in the interim that affect head.hackage's CI, which I will need to figure out a workaround for:

      • The build-9.2 job fails due to ghc!6066 (comment 371762). @bgamari has since reverted the offending commit from the ghc-9.2 branch, so once a newer GitLab bindist is available from the ghc-9.2 branch, that issue should be resolved. (It may even be available now—we'll have to see what the most recent build you triggered tells us.)
      • The build-master job fails due to the addition of the Data.ByteArray module and the Generically type in GHC.Generics. Both of these should be resolvable by making various imports more explicit. I'll handle this in a separate MR.

      My apologies for the delay on this!

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading