Skip to content
Snippets Groups Projects

Enable event logging while compiling head.hackage

Merged Bryan R requested to merge b/get-eventlogs into master
All threads resolved!

Creates a wrapper script that Cabal can call for each --make invocation. Adds tracelogs for each compiled unit.

Uses env vars to pass arguments to the wrapper through the cabal call.

Related to ghc#21585 (closed)

Merge request reports

Merge request pipeline #53041 passed

Merge request pipeline passed for edcbc8c4

Approval is optional

Merged by Bryan RBryan R 2 years ago (Jun 6, 2022 12:55pm UTC)

Merge details

Pipeline #53081 failed

Pipeline failed for edcbc8c4 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Owner

    I've been testing this locally with

    rm -r ci/run; QUICK=1 GHC=$PWD/ghc-from-artefact/bin/ghc nix run -f ci -c run-ci

    (The GHC env var is what the wrapper uses to find the real ghc. Apparently there's no good clue printed to the console if you leave it off, which I'd like to change)

    • Author Owner
      Resolved by Bryan R

      Oops, I misread the line that tars up the artifacts. I didn't notice the -C in front of -C ci/run, so the eventlogs didn't get stored.

  • Bryan R added 2 commits

    added 2 commits

    • a69007af - Include eventlogs in artifacts
    • 128b7a6a - Make --logging-wrapper optional

    Compare with previous version

  • Bryan R resolved all threads

    resolved all threads

  • Author Owner

    Ok, eventlogs are getting put into the artifact now, and they look good after downloading. I'm happy with this patch now.

  • Bryan R added 5 commits

    added 5 commits

    Compare with previous version

  • Matthew Pickering
  • Bryan R resolved all threads

    resolved all threads

  • Bryan R added 11 commits

    added 11 commits

    Compare with previous version

  • Bryan R enabled an automatic merge when the pipeline for edcbc8c4 succeeds

    enabled an automatic merge when the pipeline for edcbc8c4 succeeds

  • merged

  • Please register or sign in to reply
    Loading