Add a patch to build liquidhaskell with ghc HEAD from 2024-02-04

I couldn't find guidelines on how to run tests in CI, but I'd like to have cabal test liquidhaskell-boot:ghc-api-tests run.

Maybe something at the end of ci/config.sh?

Thank you Facundo, this will be great and I hope you will find it useful.

@facundominguez You need to add liquidhaskell as a submodule (see tests/ folder) and then add it to ci/config.sh.

It also seems you have accidentally deleted all the other patches when adding your patch.

I have also cancelled the testing jobs because they are currently broken.

mentioned in issue ghc#24096

It also seems you have accidentally deleted all the other patches when adding your patch.

I ran scripts/patch-tool drop-old before committing. I'll undo that.

added 1 commit

a0c8d47b - Add a patch to build liquidhaskell with ghc HEAD from 2024-02-04

Compare with previous version

added 1 commit

0f84e0c8 - Run liquidhaskell-boot tests in CI

Compare with previous version

Over to you. Please, let me know if there are more things to fix.

The README of head.hackage says:

The patches SHOULD work with at least GHC HEAD and a set of recent stable released GHC versions (currently this means with GHC 9.4, 9.6, 9.8, and 9.9).

Perhaps this could be a problem since different versions of liquidhaskell should be used with different versions of the compiler. The dependency bounds of the patched liquidhaskell are not going to allow building with 9.4, 9.6, and 9.8.

Could we get liquidhaskell only built and tested with GHC HEAD?

Yes, this is something that I've been thinking about as well. (We have a similar problem with singletons-base, which also targets a single version of GHC.)

A short-term solution would be to amend this list so that liquidhaskell is marked as broken (and therefore allowed to fail in CI) in all GHC versions except for 9.9.* (HEAD). It's a bit crude, but I think it would get the job done.

added 1 commit

dcf4b418 - List liquidhaskell-boot and liquidhaskell as broken in versions other than HEAD

Compare with previous version

I suspect that many of the CI failures were resolved in !351 (merged). Can you rebase this MR on top of master to incorporate these changes?

added 24 commits

dcf4b418...481d4ed0 - 21 commits from branch ghc:master
4b14e303 - Add a patch to build liquidhaskell with ghc HEAD from 2024-02-04
ed0b0343 - Run liquidhaskell-boot tests in CI
4c31d867 - List liquidhaskell-boot and liquidhaskell as broken in versions other than HEAD

Compare with previous version

added 2 commits

2db5af68 - Update dependencies and LH to new modification in GHC HEAD
d8934420 - Set liquidhaskell and liquidhaskell-boot as extra packages so they can be marked broken

Compare with previous version