Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
C
Cabal
Manage
Activity
Members
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Analyze
Contributor analytics
CI/CD analytics
Repository analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Glasgow Haskell Compiler
Packages
Cabal
Commits
fdba7ac1
Commit
fdba7ac1
authored
17 years ago
by
Duncan Coutts
Browse files
Options
Downloads
Patches
Plain Diff
Update QA TODOs and remove unneded OPTIONS -cpp
parent
c7b079be
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
Distribution/PackageDescription/QA.hs
+3
-6
3 additions, 6 deletions
Distribution/PackageDescription/QA.hs
with
3 additions
and
6 deletions
Distribution/PackageDescription/QA.hs
+
3
−
6
View file @
fdba7ac1
{-# OPTIONS -cpp #-}
-----------------------------------------------------------------------------
-- |
-- Module : Distribution.PackageDescription.QA
...
...
@@ -63,7 +62,9 @@ import Distribution.License (License(..))
-- TODO: and allmost ghc -X flags should be extensions
-- TODO: Once we implement striping (ticket #88) we should also reject
-- ghc-options: -optl-Wl,-s.
-- TODO: check that either license or license-file is set
-- TODO: keep an eye on #190 and implement when/if it's closed.
-- warn for ghc-options: -fvia-C when ForeignFunctionInterface is set
-- http://hackage.haskell.org/trac/hackage/ticket/190
data
QANotice
=
QAWarning
{
qaMessage
::
String
}
...
...
@@ -124,10 +125,6 @@ ghcSpecific pkg_descr = do
critical
$
"Instead of using -ffi or -fffi, use extensions: "
++
"ForeignFunctionInterface"
-- TODO: keep an eye on #190 and implement when/if it's closed.
-- warn for ghc-options: -fvia-C when ForeignFunctionInterface is set
-- http://hackage.haskell.org/trac/hackage/ticket/190
where
ghc_options
=
[
strs
|
bi
<-
allBuildInfo
pkg_descr
,
(
GHC
,
strs
)
<-
options
bi
]
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment