Skip to content
Snippets Groups Projects
Commit fdba7ac1 authored by Duncan Coutts's avatar Duncan Coutts
Browse files

Update QA TODOs and remove unneded OPTIONS -cpp

parent c7b079be
No related branches found
No related tags found
No related merge requests found
{-# OPTIONS -cpp #-}
-----------------------------------------------------------------------------
-- |
-- Module : Distribution.PackageDescription.QA
......@@ -63,7 +62,9 @@ import Distribution.License (License(..))
-- TODO: and allmost ghc -X flags should be extensions
-- TODO: Once we implement striping (ticket #88) we should also reject
-- ghc-options: -optl-Wl,-s.
-- TODO: check that either license or license-file is set
-- TODO: keep an eye on #190 and implement when/if it's closed.
-- warn for ghc-options: -fvia-C when ForeignFunctionInterface is set
-- http://hackage.haskell.org/trac/hackage/ticket/190
data QANotice
= QAWarning { qaMessage :: String }
......@@ -124,10 +125,6 @@ ghcSpecific pkg_descr = do
critical $ "Instead of using -ffi or -fffi, use extensions: "
++"ForeignFunctionInterface"
-- TODO: keep an eye on #190 and implement when/if it's closed.
-- warn for ghc-options: -fvia-C when ForeignFunctionInterface is set
-- http://hackage.haskell.org/trac/hackage/ticket/190
where
ghc_options = [ strs | bi <- allBuildInfo pkg_descr
, (GHC, strs) <- options bi ]
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment