* Unwrap text in templates

GitHub markdown does not do auto-unwrapping.

* Switch to one-template PR

This Stack Overflow answer [1] details how to have multiple PR templates
on GitHub. The UX is not that immediate (user has to click on preview, and
then another link).
A single page with two templates (where you fill in the one you
pick and erase the other) is more friendly.

[1] https://stackoverflow.com/a/75030350

* Whitespace

* Made PR instruction impersonal

For consistency with other bullet points.

* Revamp issue templates

* Add “Feature request” template

* Integrate Artem’s review

- `cabal` → Cabal
- add “type: enhancement” label

* Add “Documentation” issue template

* Add labels to “Bug report” template.

“type: bug” and ”needs-triage”. Suggested by Artem.

* Add “Question” issue template

* Fix typos

Spotted by Brandon.

* Fix English in “Question” template

Fix by Brandon.

Add “needs-review” to Pull Request template

As suggested by Artem.

* Split PR template in two

Split in full (PR modifies `cabal` behaviour) and simple (otherwise).

* Add Github PR Convention to PR templates

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Phil de Joux authored 1 year ago and Artem Pelenitsyn committed 1 year ago

* Change group short names

* Reference to group links

* facelift bootstrap/README.md

* fixup! facelift bootstrap/README.md

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>

* Update bootstrap/README.md

---------

Co-authored-by: brandon s allbery kf8nh <allbery.b@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Remove v2-prefix from other documentation where appropriate

* Added a changelog file

* Merge branch 'master' of github.com:haskell/cabal into remove-v2-from-docs

* Implemented PR feedback

* Reverted changes to regression tests

* Update CONTRIBUTING.md

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>

* Update bootstrap/bootstrap.py

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>

* Apply suggestions from code review

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>

* Merge branch 'master' into remove-v2-from-docs

* Removed changelog entry

* Merge branch 'remove-v2-from-docs' of github.com:aspidites/cabal into remove-v2-from-docs

* Reverted bootstrap/README.md

* Merge branch 'master' into remove-v2-from-docs

Co-authored-by: ulysses4ever <6832600+ulysses4ever@users.noreply.github.com>

Phil de Joux authored 1 year ago and Artem Pelenitsyn committed 1 year ago

* hlint --default -j . > .hlint.yaml

* Ignore modules that #include "MachDeps.h"

  Warning: Can't find file "MachDeps.h" in directories
	./cabal-testsuite/PackageTests/CmmSources/src
	.
  Asked for by: ./cabal-testsuite/PackageTests/CmmSources/src/Demo.hs  at line 8 col 1

  Warning: Can't find file "MachDeps.h" in directories
	./cabal-testsuite/PackageTests/CmmSourcesDyn/src
	.
  Asked for by: ./cabal-testsuite/PackageTests/CmmSourcesDyn/src/Demo.hs  at line 8 col 1

* Ignore the manually generated Lexer.hs

	templates/Lexer.x:10:1-20: Warning: Use fewer LANGUAGE pragmas
	Found:
	  {-# LANGUAGE CPP #-}
	  {-# LANGUAGE CPP #-}

	Perhaps:
	  {-# LANGUAGE CPP #-}

	1 hint

* Ignore templates/Paths_pkg.template.hs for its parse error

* Ignore templates/SPDX*.hs for their parse errors

* Add a linting workflow and rename the formatting one

* Redo default configuration with hlint-3.5

	I had mistakenly used a development build before:

	$ hlint --version
	HLint v3.6.20230213, (C) Neil Mitchell 2006-2022

* Shorten github workflow

workaround for #9103: skip test failing on Windows

Remove v2-prefix from Quickstart guide

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>

Closes https://github.com/haskell/cabal/issues/9086

Bump deepseq bounds to allow 1.5

README: update Matrix chat link

haddock-project fixes

`haddock-project` command need to build the project so that haddocks of
the dependencies are available in the store.

Fixes #8958.

This patch makes `haddock-project` use `--local` option by default.
Since its the default, it is removed. Also `--gen-index`,
`--gen-contents`, `--hyperlinked-source` and `--quickjump` are removed
since they are always turned on.

Added a haddock-project test.

This patch fixes a bug where a sublibrary overwrites a library
directory.  This leads to overwriting `*.haddock` files, which results
in missing entries in various indexes (e.g. the html index,
quicksearch).

cabal-install: update resolv to 0.2.0.2

Fixes #9054

Co-authored-by: Francesco Gazzetta <fgaz@fgaz.me>

* Add support for the 64-bit RISC-V architecture

* Update hashes in tests as instructed

* Fix changelog syntax

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Fix precedence for PATH for build-tools-depends

* changelog

---------

Co-authored-by: Hécate Moonlight <Kleidukos@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Add new root keys

Avoid dodgy Rep (..) import in Cabal-syntax

Fixes #9070.

Remove SandboxIndex

* Generate hie files for dependencies

* Don't fail on missing .hie files

* Add GhcOptions flag for -hiedir

* Add golden tests

* Add -hiedir to complex build info test

* Run fourmolu

* Revert "Don't fail on missing .hie files"

This reverts commit c3686d1e01e14c3b0bfe578fa2b57ea4a89a144e.

* Put .hie files in extra-compilation-artifacts

* Check ghc supports -hiedir flag

* Run fourmolu

* Add changelog

* Add extra-compilation-artifacts to buildInfo test

* Correct testLibInstallDir for Windows

* Add constant extraCompilationArtifacts

* Update changelog

* Remove redundant Maybe in Flag

* Set flagHie the same for GHCJS

Document the pkg: prefix for package targets

#8975, #8981, #8983 rebased

Oleg Grenrus authored 1 year ago and f-a committed 1 year ago

For example `parseGenericPackageDescription` validates input it passes to `readFields'`.

That is desirable: we want try to parse non-UTF8 inputs, and report as a warning if they are not UTF8. (There are non-UTF8 .cabal files on Hackage, e.g. with German names).

Oleg Grenrus authored 1 year ago and f-a committed 1 year ago

As it runs fourmolu only on modified files, it's a lot faster.

Oleg Grenrus authored 1 year ago and f-a committed 1 year ago

This is affect of using indentOfAtLeast method:
any indentation greater than current offset is fine.

That behavior is desirable to parsing multiline field contents,
but it is a bit surprising for fields, which we expect to be aligned.

Such insonsistency seems to be always a mistake, and it's easy to fix once
a machine points it out.