Correct previous markup [skip ci]

GHC-8.6.1-beta is bunded with
- binary-0.8.6.0
- time-1.8.0.2
- unix-2.7.2.2

Solver: Improve handling of failures involving whole packages, such as unknown packages.

Make GenericPackageDescription lenses more maintainable

Record synatx is easier to read and more robust against refactors.

Previously, the solver represented an unknown package with an empty PChoice
node, because an unknown package is like a package with no versions.  Now that
--reject-unconstrained-dependencies also needs to reject whole packages, it is
simpler to handle both types of failures similarly, and use a failure node for
both.  Another advantage of using a failure node now is that the node can store
more information about why the package was rejected.  The explicit node also
simplifies generating the solver log.

This commit treats a failure node under a goal choice as a backjump in
D.S.Modular.Explore.exploreLog, which fixes #5502.

The case gave the same result as a combination of two other simpler cases.

Alex Biehl authored 6 years ago and Herbert Valerio Riedel committed 6 years ago

This prevents the `--store-dir` value from being cached
and thus fixes #5504

Alex Biehl authored 6 years ago and Herbert Valerio Riedel committed 6 years ago

With `--haddock-for-hackage` we were passing `file://..` urls to the html directories; 
this was clearly undesirable and unintended.

This regression was originally introduced via d331bb08

docs: mention hiding in mixins and issues for the parsing bug

[skip ci]

Alec Theriault authored 6 years ago and Herbert Valerio Riedel committed 6 years ago

We only error-out when an explicit `--(haddock-)quickjump` is specified on a version of
Haddock that doesn't support it.

However, if `--(haddock-)quickjump` was implied by `--(haddock-)for-hackage`, we should just
warn.

Fixes #5494.

George Wilson authored 6 years ago and Herbert Valerio Riedel committed 6 years ago

[ci skip]

This restricts the solver to a closed set of packages.

Previously, even with freeze files, there was no good way to instruct
cabal-install to avoid pulling in extra, unconstrained
packages. `--reject-unconstrained-dependencies=all` forces the solver
to stay within the set of packages that are either local packages,
explicit goals, or which are explicitly constrained in configuration
files or via the `--constraint` flag

Closes #2568.

Remove a '*' kind annotation

This was failing on Mac because of clang preprocessor warnings.

(cherry picked from commit 74f65360)

Try to fix AppVeyor.

In 7d39aa01, the severity of the glob
missing directory warning was downgraded, but the test wasn't updated.
Not sure why it was passing before.

/cc @quasicomputational

(cherry picked from commit 74b91213)

See https://github.com/haskell/cabal/commit/123291c0939789aa7c3e4970c4a22adf50c0a9ee#comments.

(cherry picked from commit 8739c9b6)

This also enables and makes use of the Sphinx todo extension which
provides an idiomatic way to annotate TODO items in .rst

Ben Gamari authored 6 years ago and Mikhail Glushenkov committed 6 years ago

This will be necessary for GHC 8.6. Please do cherry-pick into the stable branch.