e.g. cabal install https://example.com/foo-1.0.tar.gz

The initial patch would always try to use HTTPS, even when the repo
specified to use HTTP. This works for the central community hackage
but obviously does not work in general.

The new logic is that we always follow what is specified for the
remote repo in the config, except for built-in known repos (currently
just the central community hackage) where we mark them as also
supporting https. For upload when uploading to such a marked repo
then we will try https and will complain if the plain-http impl was
selected automatically (but it's ok if selected manually).

This patch also changes things so that for http urls on download, we
stick to the builtin http impl by default, and only use the external
ones if https support is required (i.e. because the repo was
configured to use an https url)

Move utils into other Util modules.
Reformat all code to 80 cols.
Reorder code and add more comments.
Use long form style program args, e.g. --silent rather than -s
Finish implementation of form upload with wget
Fix reporting of server error messages for upload (curl & builtin)
Implement collecting of ETags for curl and wget.
Fix wget for case of 304 not modified response (wget uses exit code 8).
Rework transport configuration phase.

gershomb authored 9 years ago and Duncan Coutts committed 9 years ago

Supports both uploading and downloading.
Basic built-in HTTP is still supported.

Get 'builddir' from cabal.config or CABAL_BUILDDIR

This will be useful for adding crypto credentials without people having
to update their config files.

Also useful point to add any other special casing for known repos.

Will need a later check to validate the repo info, e.g. that it's a
supported url scheme and is an absolute URI.

Add test dependencies to stack.yaml

Support new section syntax for remote-repo.

Fixes #2484. The 'builddir' option may now be specified in cabal.config
as well. It will also be read from the CABAL_BUILDDIR environment
variable, if set. The order of precedence (highest to lowest) is:
1. --builddir command line option
2. CABAL_BUILDDIR environment variable
3. cabal.config setting

Drop pkgna_ prefix from package keys, c.f. http://ghc.haskell.org/tra…

HACKING.md: Add quotation to sed command

The command line given to get the sandbox package database path is missing quotation which may make it fail in some shells (given certain globbing options). This adds single quotation marks to avoid such potential issues.

Add a stack.yaml file

I needed this when building cabal.exe for MinGHC (see:
https://github.com/fpco/minghc/issues/69). I thought others might find
this useful, especially for the use case of bootstrapping cabal
development.

I went the direction of no curation and explicit packages in the
extra-deps, as I thought that would make more sense for a project low on
the dependency chain, but this could certainly be tweaked to use LTS
Haskell or Stackage Nightly instead.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Allow cabal freeze tests to run on Windows

The tests now read cabal.config strictly so that the file is closed by the time
it is deleted for the next test.

Fix #367. Find module files in all source directories.

Test cabal exec error message in a more portable way

Compare file paths with equalFilePath for portability

Without this change, differences in filename capitalization caused "cabal
sandbox delete" to fail with this error message when used with a default
sandbox on Windows:

cabal.exe: Non-default sandbox location used:
'C:\folder\.cabal-sandbox'.
Assuming a shared sandbox. Please delete
'C:\folder\.cabal-sandbox' manually.

This commit also allows the cabal-install package tests that delete sandboxes
to run on Windows.

This change allows the tests "can run executables installed in the sandbox" and
"adds the sandbox bin directory to the PATH" to run on Windows by removing the
executable name from the required error message.

Automatically run `configure` before `haddock`

Parse C compiler flags from GHC correctly

Instead of:
C:\Users\Ganesh\AppData\Local\Temp\data-default-instances-old-locale-0.0.1-11924\data-default-instances-old-locale-0.0.1
(which was the case before @ezyang's patch)
we now get:
C:\Users\Ganesh\AppData\Local\Temp\cabal-tmp-11924\data-default-instances-old-locale-0.0.1

Fixes #2658.

Only warn for missing Setup.hs if build type isn't Simple

Because cabal sdist will add a default Setup.hs anyway

Instead of:
C:\Users\Ganesh\AppData\Local\Temp\data-default-instances-old-locale-0.0.1-11924\data-default-instances-old-locale-0.0.1
we get:
C:\Users\Ganesh\AppData\Local\Temp\data-default-instances-old-locale-0.0.1-11924

Instead of:
dist\build\libHSdata-default-instances-old-locale-0.0.1-6jcjjaR25tK4x3nJhHHjFM.a-11924\libHSdata-default-instances-old-locale-0.0.1-6jcjjaR25tK4x3nJhHHjFM.a
we get:
dist\build\objs-11924\libHSdata-default-instances-old-locale-0.0.1-6jcjjaR25tK4x3nJhHHjFM.a

This should put us under the limit.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

GHC hands us a String which we previously tried to parse as a [String],
causing GHC's compiler flags to be ignored.