Remove RPATH workaround

Maybe 7 years ago it was relevant but it seems today it is not needed
anymore.

* Cabal Package Exceptions

* Accepting new format of output with error codes

* Reverting the changes to new error output

* Rebasing branch Subsequent Cabal Package errors

* Added setup-explicit-fail.out

* Delete setup-explicit-fail.out

* Accepting new output with error codes

* Changed to "GetProgramInvocationException" and "SanityCheckForEnableComponents"

* Going back to former die' call in `getProgramInvocationOutout`  function to check on the failing CI test

* Accepted new error output, included cabalexception in handler

* Error code rectification

* Added a handler condition for VerboseException CabalException in `annotaeFailure` function

* Leaving "GetProgramInvocationException" unmodified

* Incorporated review comments

* Updated "nor" in AutoGenModule test case

* Updated "AutogenExposeOther" test case which was dependent on this "nor" change

Address CVE-2023-37920

bump certifi to 2023.07

https://nvd.nist.gov/vuln/detail/CVE-2023-37920
https://github.com/certifi/python-certifi/security/advisories/GHSA-xqr8-7jwr-rhp7

* Add alex to build-tool-depends and remove separate code gen

- Pass latin-1 encoding is passed as input pragma
- Cabal hard-codes -g for alex so we don't need to worry about --ghc
- Rework bootstrap, adding per-component building
- Update bootstrap plans

* [bootstrap] warn the user if cabal config is not found

* [bootstrap] regenerate bootstrap plans once more

* [bootstrap] regenerate bootstrap files after #9139

Combine non-installable and non-upgradable package lists (fixes #8581)

* Subsequent Cabal Exceptions

* Accepting new ouput with error codes

* Changed to "VersionMismatch"

* Accepting new test outputs with error codes

* "UnrecognisedBuildTarget" processing moved to error handler

* Changes in type definition for constructors "ReportBuildTargetProblems", "UnknownBuildTarget", "AmbiguousBuildTarget"

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Do not ask overwrite questions for empty dirs

See #9150, blank projects need not to ask permission to
overwrite files.

* Fix tests

"test-dir" [] are the mock calls to `getPackageDir` and `listDirectory`

The TODO deleted in 4d3f7b5e suggests that the
special case was only needed for the top-down solver, which has been removed.

This commit continues the work in b016e597 to
combine the lists of non-installable and non-upgradable packages. When a package
is in the list, it means that the solver will only consider installed instances
of that package. This commit renames the list from "non-upgradable" to
"non-reinstallable" to clarify that the packages cannot be upgraded or
downgraded. There should be no change in behavior, except for the wording of
solver error messages.

Add changelog for #9113

Fixes #9122

* I have added a function "dieWithException" which will replace the die' calls and throws Error types as exception.
CabalException will hold all ErrorTypes, types will be incrementally added per module.
The VerboseException a will have CabalException and cabalInstallException variously in the a position

Utils.hs
1. Creation of Error data types
2. Diewithexception and exceptionCode function
3. Instance for VerboseException

Bench.hs and install.hs
1. Replaced die' call sites with dieWithException

Right now I have only added errors from two modules Distribtuion/Simple/Bench and Distribution/Simple/Install. Error types will be added incrementally.

* Codebase is formatted with fourmolu and compiled without warnings.

* Enabled fourmolu action

* Running fourmolu through github action as the previous ones failed.

* Function `exceptionWithMetadata` and constructors for each exception type

* I have added a function "dieWithException" which will replace the die' calls and throws Error types as exception.
CabalException will hold all ErrorTypes, types will be incrementally added per module.
The VerboseException a will have CabalException and cabalInstallException variously in the a position

Utils.hs
1. Creation of Error data types
2. Diewithexception and exceptionCode function
3. Instance for VerboseException

Bench.hs and install.hs
1. Replaced die' call sites with dieWithException

Right now I have only added errors from two modules Distribtuion/Simple/Bench and Distribution/Simple/Install. Error types will be added incrementally.

* Codebase is formatted with fourmolu and compiled without warnings.

* Enabled fourmolu action

* Running fourmolu through github action as the previous ones failed.

* Function `exceptionWithMetadata` and constructors for each exception type

* Updated changelog

* PatternMatching cases of diewithexception and displayexception reduced

* Delete fourmolu.yaml

This file is redundant.

* Delete settings.json

This file is redundant.

* Replaced die' calls for modules srcDist.hs and HcPkg.hs

* Replaced die' calls in modules `build.hs`,`Haddock.hs` and `Program.hs`

* Replaced die' calls in modules `Build.hs`, `Haddock.hs` and `Program.hs`

* Replaced die' calls in modules `GHCJS.hs`, `HaskellSuite.hs` and `BuildPaths.hs`

* Formatted the codebase with Fourmolu

* Accepted the new output with error codes and adding the file relevant to the test

* Changes in `Utils.hs` and `Errors.hs` to reflect the new error codes

* Keeping rip intact

* test changes

* CallStack unmarked from the error output

* callstack unmarked from output

* unmarked callstack in test output

* Format the codebase with fourmolu

* Changed to Error identifier to "Cabal-"

* Updated Constructors as per review comments

* Rectifying Hlint warning

---------

Co-authored-by: Gershom Bazerman <gershom@arista.com>

Add support for using GHC's -jsem option

Matthew Pickering authored 2 years ago and Ben Gamari committed 1 year ago

* The top-level user interface to enable the use of the semaphore is the
  `--semaphore` flag. If you pass `-j4 --semaphore` then cabal will
  create a semaphore with 4 slots which is passed to ghc using the
  `-jsem` option so that all GHC processes coordinate to use 4
  capabilities.

  - The semaphore logic is provided by a new package `semaphore-compat`
    which provides a cross-platform abstraction for semaphores.

* The low level `./Setup.hs build` interface accepts the `--semaphore
  <SEMAPHORE>` option, which can be used to directly pass the semaphore
  you require to the Setup script.

Ben Gamari authored 1 year ago and Artem Pelenitsyn committed 1 year ago

In #9064 we discovered that `ghc-boot` was added to the
non-reinstallable package set due to #8051 despite there being no
reason why it can't be built from its source distribution. This
revealed the fact that there is quite some ambiguity around what
constitutes a non-reinstallable package.

In #9064 we worked out a hopefully-more-clear picture of
non-reinstallability. Here we update the commentary to describe this
concept and update the lists to reflect the new definition.

Closes #9064.

If a pull request gets the "merge+no rebase" label, it' will be merged directly to master without a rebase/squash or queue. This can be useful in cases when contributors don't allow updating their branches.

Use case insensitive match on ETag headers

Fixes #9113.

* WIP support asm/cmm/js sources in executable components (#8639)

* Factorise extra src code for lib/exe and add extra exe src tests

* Add extra sources to linking step

* lint

* lint

* Don't build js sources for executables on non-js hosts

* Fix cabal.out for CmmSourcesExe test and lint

* Update changelog

* Slight changes

* Fix PROCS for Darwin

* Add fixity information

* Fix file exclusions

* Fix formatting

* Fix CI linting

* Simplify 'make style' without 'find'

* Add in backwards-compatible fourmolu 0.13 config

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Add 'mkVersionIntervals' for creating a VersionIntervals from a list

* Update changelog.d/pr-9034

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>

* Apply suggestions from code review

---------

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>

f-a authored 1 year ago and Artem Pelenitsyn committed 1 year ago

Labels are not supported in PR templates, see
https://github.com/orgs/community/discussions/12815

Add user-oriented resources in README.md

Manual and venues where to (h)ask questions.

* Unwrap text in templates

GitHub markdown does not do auto-unwrapping.

* Switch to one-template PR

This Stack Overflow answer [1] details how to have multiple PR templates
on GitHub. The UX is not that immediate (user has to click on preview, and
then another link).
A single page with two templates (where you fill in the one you
pick and erase the other) is more friendly.

[1] https://stackoverflow.com/a/75030350

* Whitespace

* Made PR instruction impersonal

For consistency with other bullet points.

* Revamp issue templates

* Add “Feature request” template

* Integrate Artem’s review

- `cabal` → Cabal
- add “type: enhancement” label

* Add “Documentation” issue template

* Add labels to “Bug report” template.

“type: bug” and ”needs-triage”. Suggested by Artem.

* Add “Question” issue template

* Fix typos

Spotted by Brandon.

* Fix English in “Question” template

Fix by Brandon.

Add “needs-review” to Pull Request template

As suggested by Artem.

* Split PR template in two

Split in full (PR modifies `cabal` behaviour) and simple (otherwise).

* Add Github PR Convention to PR templates

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Phil de Joux authored 1 year ago and Artem Pelenitsyn committed 1 year ago

* Change group short names

* Reference to group links

* facelift bootstrap/README.md

* fixup! facelift bootstrap/README.md

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>

* Update bootstrap/README.md

---------

Co-authored-by: brandon s allbery kf8nh <allbery.b@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Remove v2-prefix from other documentation where appropriate

* Added a changelog file

* Merge branch 'master' of github.com:haskell/cabal into remove-v2-from-docs

* Implemented PR feedback

* Reverted changes to regression tests

* Update CONTRIBUTING.md

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>

* Update bootstrap/bootstrap.py

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>

* Apply suggestions from code review

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>

* Merge branch 'master' into remove-v2-from-docs

* Removed changelog entry

* Merge branch 'remove-v2-from-docs' of github.com:aspidites/cabal into remove-v2-from-docs

* Reverted bootstrap/README.md

* Merge branch 'master' into remove-v2-from-docs

Co-authored-by: ulysses4ever <6832600+ulysses4ever@users.noreply.github.com>