Move Distribution.Client.Compat.Prelude to Distribution.Compat.Prelude

The idea here is to break the dependency that has crept in from the
"Solver" into the "Client". (If there's ever going to be a separate
solver then the dependency would become a big problem.)

Fixes #4566.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Solver: Refactor Validate.hs.

Refactor goal sorting in the solver DSL.

This just moves some functions and types into Validate.hs in preparation for
#4391.

Now DSL.exResolve takes a goal-ordering function, which is more flexible
than a list of sorted goals.

[ci skip]

This reverts commit 8b563d4c.

Herbert Valerio Riedel authored 7 years ago and Mikhail Glushenkov committed 7 years ago

GHC 8.2.1 appears to take significantly longer to compile the code
and pushes us over the Travis job time limit.

[ci skip]

Fix test suite wobbliness on GHC 8.2.

Here were the root causes:

- Some tests involving Custom setpu showed MORE output
  (UseLocalPackageForSetup) when run on GHC 8.2.  This is because GHC
  8.2 ships a recent enough version of Cabal to know how to emit
  markers, which means we have started picking up the output.  I hacked
  up these tests to not accept this output, but a more correct thing to
  do is figure out how to NOT request marking of a Setup script which is
  not the inplace install.  This was a little tricky so I bailed.

- GHC 8.2 no longer emits "It is a member of the hidden package".
  This broke CustomWithoutCabalDefaultMain.  Not sure if this
  is a GHC regression but it's pretty harmless.

- While I was at it, I fixed an inexhaustive pattern match in
  cabal-testsuite (though perhaps poorly; I couldn't figure out
  what the new constructor does.)

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Make new-haddock --haddock-for-hackage generate doc tarball

fixes #4521

Add constraints and preferences to the solver QuickCheck tests, and add a new test.

[ci skip]

Workaround invalid .cabal files with Main modules in other-extensions

The value was always Modular.

`other-modules` is intended for non-main modules (which is also stated
in the cabal manual). Unfortunately, a few packages, such as `happy` do
incorrectly specify `other-modules: Main` for their executables, thereby
causing GHC to complain about duplicate Main modules.

The workaround implemented here is to filter out the main module
name (while taking into account `ghc-options: -main-is ...`) from the
`other-modules` passed to GHC, and emit a warning in the process.

Refactor ProjectConfig Arbitrary instances

Use record syntax instead of positional arguments

this should hopefully silence all 4 combinations of flag(lib)
and flag(monolithic).

`cabal-install.cabal` would greatly benefit from common stanzas (#2832)
as it would help reduce the redundancy singnificantly.

This was missed in the original commit because it requires a different
flag(lib) setting...

This allows us to use the versions of those two packages as bundled w/
GHC 8.2.1.

Pass -Wmissing-home-modules to all component types

i.e. not only library components, but also executables,
tests and benchmarks.

This addresses the other half of #4528

Pass `other-modules` to `ghc --make` for exe components

`gbuildSources` was introduced by a refactoring in
382143aa but there
doesn't appear to be a good reason why the modules are
only passed for a non-haskell main module.

So this patch consistently passes `other-modules` to
`ghc --make` for both variants of executables.

Addresses part of #4528

Only the most recent 0.13.* release is compatible w/ GHC 8.2.1 and all
its bundled library versions.

Filter `+timestamp` out when invoking Cabal-2.0.0 custom-setups

This appears to be somewhat redundant, since there's also the
SetupWrapper hack in place which also filters out `+timestamp` for
externally invoked commands other than `configure`, but it's "good
style" to keep `filterConfigureFlags` in sync for the sake of
consistency.

The hack introduced in eb0593ed is now
extended to filter out the verbosity +timestamp flag (see #4518) for
Cabal versions prior to Cabal-2.1 which didn't yet support it.